Page MenuHomePhabricator
Differential D10761

[lib] refactor login action in `keyserver-reducer` to ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:02 AM.
Tags
None
Referenced Files
F5238986: D10761.diff
Sat, Apr 5, 6:43 PM
Unknown Object (File)
Feb 21 2025, 11:41 AM
Unknown Object (File)
Feb 21 2025, 11:41 AM
Unknown Object (File)
Feb 21 2025, 11:41 AM
Unknown Object (File)
Feb 21 2025, 11:40 AM
Unknown Object (File)
Jan 22 2025, 5:46 AM
Unknown Object (File)
Jan 5 2025, 3:39 PM
Unknown Object (File)
Dec 28 2024, 2:48 PM
View All 64 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMMcb5c2bbdb2ad: [lib] refactor login action in `keyserver-reducer` to ops
Summary

Convert logic to ops approach.

Depends on D10760

Test Plan
  1. Login on both web and native and check if keyserver store has proper state.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
reducers/
22 lines

Diff 36392

View Options

lib/reducers/keyserver-reducer.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Text } from 'react-native'; import { View, Text } from 'react-native';
import QRCode from 'react-native-qrcode-svg'; import QRCode from 'react-native-qrcode-svg';
import { qrCodeLinkURL } from 'lib/facts/links.js'; import { qrCodeLinkURL } from 'lib/facts/links.js';
import { useSecondaryDeviceLogIn } from 'lib/hooks/login-hooks.js'; import { useSecondaryDeviceLogIn } from 'lib/hooks/login-hooks.js';
import { useQRAuth } from 'lib/hooks/qr-auth.js'; import { useQRAuth } from 'lib/hooks/qr-auth.js';
import { uintArrayToHexString } from 'lib/media/data-utils.js'; import { uintArrayToHexString } from 'lib/media/data-utils.js';
import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { BackupKeys } from 'lib/types/backup-types.js'; import type { BackupKeys } from 'lib/types/backup-types.js';
import { getContentSigningKey } from 'lib/utils/crypto-utils.js'; import { getContentSigningKey } from 'lib/utils/crypto-utils.js';
import { getMessageForException } from 'lib/utils/errors.js';
import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js'; import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js';
import { import {
composeTunnelbrokerQRAuthMessage, composeTunnelbrokerQRAuthMessage,
parseTunnelbrokerQRAuthMessage, parseTunnelbrokerQRAuthMessage,
} from './qr-code-utils.js'; } from './qr-code-utils.js';
import { commCoreModule } from '../native-modules.js'; import { commCoreModule } from '../native-modules.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
import * as AES from '../utils/aes-crypto-module.js'; import * as AES from '../utils/aes-crypto-module.js';
import {
appOutOfDateAlertDetails,
unknownErrorAlertDetails,
} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type QRCodeScreenProps = { type QRCodeScreenProps = {
+navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>, +navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>,
+route: NavigationRoute<'QRCodeScreen'>, +route: NavigationRoute<'QRCodeScreen'>,
}; };
function performBackupRestore(backupKeys: BackupKeys): Promise<void> { function performBackupRestore(backupKeys: BackupKeys): Promise<void> {
Show All 28 Linesfunction QRCodeScreen(props: QRCodeScreenProps): React.Node {
const secondaryDeviceLogIn = useSecondaryDeviceLogIn(); const secondaryDeviceLogIn = useSecondaryDeviceLogIn();
const performRegistration = React.useCallback( const performRegistration = React.useCallback(
async (userID: string) => { async (userID: string) => {
try { try {
await secondaryDeviceLogIn(userID); await secondaryDeviceLogIn(userID);
} catch (err) { } catch (err) {
console.error('Secondary device registration error:', err); console.error('Secondary device registration error:', err);
Alert.alert('Registration failed', 'Failed to upload device keys', [ const messageForException = getMessageForException(err);
{ text: 'OK' }, if (
]); messageForException === 'client_version_unsupported' ||
messageForException === 'Unsupported version'
) {
Alert.alert(
appOutOfDateAlertDetails.title,
appOutOfDateAlertDetails.message,
);
} else {
Alert.alert(
unknownErrorAlertDetails.title,
unknownErrorAlertDetails.message,
);
}
void generateQRCode(); void generateQRCode();
} }
}, },
[secondaryDeviceLogIn, generateQRCode], [secondaryDeviceLogIn, generateQRCode],
); );
React.useEffect(() => { React.useEffect(() => {
void generateQRCode(); void generateQRCode();
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines