Differential D10768

[lib] refactor updating connection status in `keyserver-reducer` to ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 25, 5:25 PM

	Unknown Object (File)
	Feb 14 2025, 12:30 PM

	Unknown Object (File)
	Feb 14 2025, 12:30 PM

	Unknown Object (File)
	Feb 14 2025, 12:29 PM

	Unknown Object (File)
	Feb 14 2025, 12:29 PM

	Unknown Object (File)
	Feb 2 2025, 4:50 PM

	Unknown Object (File)
	Jan 31 2025, 12:04 PM

	Unknown Object (File)
	Jan 31 2025, 12:04 PM

View All 68 Files

Subscribers

Details

Reviewers

Commits

rCOMMa08fbed18e56: [lib] refactor updating connection status in `keyserver-reducer` to ops

Summary

Convert logic to ops approach.

Depends on D10763

Test Plan

Open app
Kill keyserver
Check if state is set

Tested on both native and web

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jan 22 2024, 3:30 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:30 AM

kamil added a child revision: D10769: [lib] refactor activity-related code in `keyserver-reducer` to ops.Jan 22 2024, 3:32 AM

kamil edited parent revisions, added: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops; removed: D10763: [lib] refactor state-sync actions in `keyserver-reducer` to ops.Jan 22 2024, 3:35 AM

Harbormaster completed remote builds in B25995: Diff 35927.Jan 22 2024, 3:50 AM

kamil published this revision for review.Jan 22 2024, 6:36 AM

inka accepted this revision.Jan 22 2024, 9:31 AM

This revision is now accepted and ready to land.Jan 22 2024, 9:31 AM

Closed by commit rCOMMa08fbed18e56: [lib] refactor updating connection status in `keyserver-reducer` to ops (authored by kamil). · Explain WhyJan 31 2024, 8:23 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa08fbed18e56: [lib] refactor updating connection status in `keyserver-reducer` to ops.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

28 lines

Diff 35927

lib/reducers/keyserver-reducer.js

	Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines		return ops.map(operation => {
	}			}
	return {			return {
	type: 'replace_dm_operation',			type: 'replace_dm_operation',
	payload: convertDMOperationIntoClientDBDMOperation(operation.payload),			payload: convertDMOperationIntoClientDBDMOperation(operation.payload),
	};			};
	});			});
	}			}

				function convertClientDBDMOperationToDMOperation(
				operation: ClientDBDMOperation,
				): Operation {
				return {
				id: operation.id,
				type: operation.type,
				operation: JSON.parse(operation.operation),
				};
				}

	export {			export {
	convertDMOperationIntoClientDBDMOperation,			convertDMOperationIntoClientDBDMOperation,
	convertDMOperationOpsToClientDBOps,			convertDMOperationOpsToClientDBOps,
				convertClientDBDMOperationToDMOperation,
	};			};