Page MenuHomePhabricator
Differential D10773

[lib] refactor `reduceKeyserverStore` to return ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:42 AM.
Tags
None
Referenced Files
F3354199: D10773.diff
Sat, Nov 23, 12:20 PM
Unknown Object (File)
Wed, Nov 6, 4:18 PM
Unknown Object (File)
Oct 15 2024, 7:57 AM
Unknown Object (File)
Oct 15 2024, 7:57 AM
Unknown Object (File)
Oct 15 2024, 7:57 AM
Unknown Object (File)
Oct 15 2024, 7:57 AM
Unknown Object (File)
Oct 15 2024, 7:57 AM
Unknown Object (File)
Oct 15 2024, 7:57 AM
View All 87 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMM4df683cd553b: [lib] refactor `reduceKeyserverStore` to return ops
Summary

Return ops to process in on DB later.

Test Plan

flow - just a refactor

Diff Detail

Repository
rCOMM Comm
Branch
land-ks-store
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jan 22 2024, 3:42 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:42 AM
Harbormaster failed remote builds in B26001: Diff 35933!Jan 22 2024, 3:58 AM
kamil updated this revision to Diff 35949.Jan 22 2024, 4:28 AM

rebase

Harbormaster completed remote builds in B26015: Diff 35949.Jan 22 2024, 4:48 AM
kamil added a child revision: D10784: [native][web] migrate keyservers to SQLite.Jan 22 2024, 5:52 AM
kamil published this revision for review.Jan 22 2024, 6:37 AM
inka accepted this revision.Jan 22 2024, 9:43 AM
This revision is now accepted and ready to land.Jan 22 2024, 9:43 AM
kamil mentioned this in D10755: [lib] implement `KeyserverStore` spec.Jan 27 2024, 8:18 AM
ashoat added a comment.Jan 30 2024, 12:34 PM

Hey @kamil, can you run arc diff for this diff again, so that it reflects the latest version of D10760? I want to arc patch this diff for my work in ENG-6856, but it's currently giving me an out-of-date version of D10760

kamil edited parent revisions, added: D10883: [lib] refactor deleting keyserver account `keyserver-reducer` to ops; removed: D10772: [lib] refactor setting device token in `keyserver-reducer` to ops.Jan 31 2024, 5:47 AM
kamil updated this revision to Diff 36383.Jan 31 2024, 7:27 AM
kamil added a parent revision: D10772: [lib] refactor setting device token in `keyserver-reducer` to ops.

rebase

kamil removed a parent revision: D10772: [lib] refactor setting device token in `keyserver-reducer` to ops.Jan 31 2024, 7:29 AM
Harbormaster completed remote builds in B26330: Diff 36383.Jan 31 2024, 7:46 AM
kamil edited the summary of this revision. (Show Details)Jan 31 2024, 8:05 AM
kamil updated this revision to Diff 36387.Jan 31 2024, 8:06 AM
kamil edited the summary of this revision. (Show Details)

rebase

This revision was landed with ongoing or failed builds.Jan 31 2024, 8:23 AM
Closed by commit rCOMM4df683cd553b: [lib] refactor `reduceKeyserverStore` to return ops (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM4df683cd553b: [lib] refactor `reduceKeyserverStore` to return ops.
Harbormaster completed remote builds in B26334: Diff 36387.Jan 31 2024, 8:24 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
169 lines
3 lines
2 lines

Diff 36383

View Options

lib/reducers/keyserver-reducer.js

Loading...
View Options

lib/reducers/keyserver-reducer.test.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...