[lib] Retry auth
ClosedPublic
Actions

Authored by tomek on Jan 26 2024, 5:12 PM.

Details

Reviewers

varun
inka
kamil

Commits

rCOMM4111f6f08744: [lib] Retry auth

Summary

Retry the auth, if it wasn't successful, every 1 minute. We can change the delay if we think something else would work better.

Depends on D10843

Test Plan

Add a console log checking if unsuccessful auth is retried.

Diff Detail

Repository

rCOMM Comm

Branch

handlers-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jan 26 2024, 5:12 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 26 2024, 5:12 PM

Harbormaster completed remote builds in B26199: Diff 36187.Jan 26 2024, 5:44 PM

tomek requested review of this revision.Jan 26 2024, 5:44 PM

ashoat mentioned this in D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.Jan 27 2024, 3:13 AM

ashoat added inline comments.

lib/components/keyserver-connection-handler.js
154–156 ↗	(On Diff #36187)	I think this is more readable

varun accepted this revision.Jan 30 2024, 3:54 AM

This revision is now accepted and ready to land.Jan 30 2024, 3:54 AM

Use sleep

Harbormaster completed remote builds in B26299: Diff 36347.Jan 30 2024, 4:41 PM

tomek added a child revision: D10884: [lib] Cancel an auth every time dependencies change.Jan 31 2024, 3:29 PM

Closed by commit rCOMM4111f6f08744: [lib] Retry auth. · Explain WhyFeb 5 2024, 3:23 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM4111f6f08744: [lib] Retry auth.

Revision Contents
Changeset List

Path

Size

lib/

components/

keyserver-connection-handler.js

14 lines

Diff 36347

View Options

lib/components/keyserver-connection-handler.js

[lib] Retry authClosedPublicActions