Page MenuHomePhabricator
Differential D10844

[lib] Retry auth
ClosedPublic
Actions

Authored by tomek on Jan 26 2024, 9:12 AM.
Tags
None
Referenced Files
F3372596: D10844.diff
Tue, Nov 26, 7:13 AM
Unknown Object (File)
Fri, Nov 22, 10:03 PM
Unknown Object (File)
Wed, Nov 13, 1:04 PM
Unknown Object (File)
Wed, Nov 6, 5:09 AM
Unknown Object (File)
Tue, Nov 5, 10:00 PM
Unknown Object (File)
Tue, Nov 5, 9:43 PM
Unknown Object (File)
Tue, Nov 5, 7:45 PM
Unknown Object (File)
Wed, Oct 30, 1:54 AM
View All 58 Files
Subscribers
ashoat

Details

Reviewers
varun
inka
kamil
Commits
rCOMM4111f6f08744: [lib] Retry auth
Summary

Retry the auth, if it wasn't successful, every 1 minute. We can change the delay if we think something else would work better.

Depends on D10843

Test Plan

Add a console log checking if unsuccessful auth is retried.

Diff Detail

Repository
rCOMM Comm
Branch
handlers-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jan 26 2024, 9:12 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 26 2024, 9:12 AM
Harbormaster completed remote builds in B26199: Diff 36187.Jan 26 2024, 9:44 AM
tomek requested review of this revision.Jan 26 2024, 9:44 AM
ashoat mentioned this in D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.Jan 26 2024, 7:13 PM
ashoat added inline comments.
lib/components/keyserver-connection-handler.js
154–156 ↗(On Diff #36187)

I think this is more readable

varun accepted this revision.Jan 29 2024, 7:54 PM
This revision is now accepted and ready to land.Jan 29 2024, 7:54 PM
tomek updated this revision to Diff 36347.Jan 30 2024, 8:21 AM
tomek marked an inline comment as done.

Use sleep

Harbormaster completed remote builds in B26299: Diff 36347.Jan 30 2024, 8:41 AM
tomek added a child revision: D10884: [lib] Cancel an auth every time dependencies change.Jan 31 2024, 7:29 AM
Closed by commit rCOMM4111f6f08744: [lib] Retry auth (authored by tomek). · Explain WhyFeb 5 2024, 7:23 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM4111f6f08744: [lib] Retry auth.

Revision Contents
Changeset List

PathSize
lib/
components/
14 lines

Diff 36347

View Options

lib/components/keyserver-connection-handler.js

Loading...