Paths

Table of Contentst

-
native/account/
-
account/
-
siwe-panel.react.js

[native] use identityGenerateNonce in SIWEPanel component
ClosedPublic
Actions

Authored by varun on Jan 30 2024, 8:25 PM.

Details

Reviewers

ashoat
inka

Commits

rCOMM5900d8e9de00: [native] use identityGenerateNonce in SIWEPanel component

Summary

NOTE: SIWE won't work yet if usingCommServicesAccessToken is enabled.

This change just sets the nonce state variable to the value received from the identity service

Depends on D10880

Test Plan

logged the nonce and confirmed that the state variable was set successfully

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jan 30 2024, 8:25 PM

Harbormaster completed remote builds in B26316: Diff 36364.Jan 30 2024, 8:43 PM

varun requested review of this revision.Jan 30 2024, 8:43 PM

tomek requested changes to this revision.Jan 31 2024, 1:28 AM

tomek added inline comments.

native/account/siwe-panel.react.js
89–106	This shouldn't work and the test plan should fail in this case, so I'm a little surprised. We don't await a promise passed to `dispatchActionPromise` which makes it possible that `setNonce` will be called without `response` being set. The `setNonce` call should be kept inside the promises, just like it was before this diff.

This revision now requires changes to proceed.Jan 31 2024, 1:28 AM

ashoat mentioned this in D10880: [lib][native][web] add generate nonce action types.Jan 31 2024, 8:24 AM

ashoat added inline comments.

native/account/siwe-panel.react.js
64–66	Doesn't this need to be modified for your new action type?

address feedback

varun added inline comments.Feb 1 2024, 10:29 AM

native/account/siwe-panel.react.js
64–66	yes, was going to be the next diff but makes more sense in this one
89–106	you're right, i was logging `response` inside the promise passed to `dispatchActionPromise`, not the `nonce` state variable

Harbormaster completed remote builds in B26430: Diff 36543.Feb 1 2024, 10:46 AM

Accepting on @tomek's behalf, as he's off until Monday

ashoat removed a reviewer: tomek.Feb 1 2024, 11:25 AM

This revision is now accepted and ready to land.Feb 1 2024, 11:25 AM

varun added a child revision: D10958: [native] rename siwe auth loading status selector.Feb 5 2024, 9:53 PM

Closed by commit rCOMM5900d8e9de00: [native] use identityGenerateNonce in SIWEPanel component (authored by varun). · Explain WhyFeb 7 2024, 9:57 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM5900d8e9de00: [native] use identityGenerateNonce in SIWEPanel component.

Revision Contents
Changeset List

Path

Size

native/

account/

siwe-panel.react.js

32 lines

Diff 36364

View Options

native/account/siwe-panel.react.js

Show All 13 Lines
import androidx.core.app.NotificationCompat;		import androidx.core.app.NotificationCompat;
import androidx.lifecycle.Lifecycle;		import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.ProcessLifecycleOwner;		import androidx.lifecycle.ProcessLifecycleOwner;
import androidx.localbroadcastmanager.content.LocalBroadcastManager;		import androidx.localbroadcastmanager.content.LocalBroadcastManager;
import app.comm.android.ExpoUtils;		import app.comm.android.ExpoUtils;
import app.comm.android.MainActivity;		import app.comm.android.MainActivity;
import app.comm.android.R;		import app.comm.android.R;
import app.comm.android.aescrypto.AESCryptoModuleCompat;		import app.comm.android.aescrypto.AESCryptoModuleCompat;
import app.comm.android.commservices.CommAndroidBlobClient;		import app.comm.android.commservices.CommAndroidServicesClient;
import app.comm.android.fbjni.CommMMKV;		import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore;		import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.GlobalDBSingleton;		import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.fbjni.MessageOperationsUtilities;		import app.comm.android.fbjni.MessageOperationsUtilities;
import app.comm.android.fbjni.NetworkModule;		import app.comm.android.fbjni.NetworkModule;
import app.comm.android.fbjni.NotificationsCryptoModule;		import app.comm.android.fbjni.NotificationsCryptoModule;
import app.comm.android.fbjni.StaffUtils;		import app.comm.android.fbjni.StaffUtils;
import app.comm.android.fbjni.ThreadOperations;		import app.comm.android.fbjni.ThreadOperations;
Show All 33 Lines	public class CommNotificationsHandler extends FirebaseMessagingService {
// Those and future MMKV-related constants should match		// Those and future MMKV-related constants should match
// similar constants in NotificationService.mm		// similar constants in NotificationService.mm
private static final String MMKV_KEY_SEPARATOR = ".";		private static final String MMKV_KEY_SEPARATOR = ".";
private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER";		private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER";
private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT";		private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT";
private Bitmap displayableNotificationLargeIcon;		private Bitmap displayableNotificationLargeIcon;
private NotificationManager notificationManager;		private NotificationManager notificationManager;
private LocalBroadcastManager localBroadcastManager;		private LocalBroadcastManager localBroadcastManager;
private CommAndroidBlobClient blobClient;		private CommAndroidServicesClient servicesClient;
private AESCryptoModuleCompat aesCryptoModule;		private AESCryptoModuleCompat aesCryptoModule;

public static final String RESCIND_KEY = "rescind";		public static final String RESCIND_KEY = "rescind";
public static final String RESCIND_ID_KEY = "rescindID";		public static final String RESCIND_ID_KEY = "rescindID";
public static final String TITLE_KEY = "title";		public static final String TITLE_KEY = "title";
public static final String PREFIX_KEY = "prefix";		public static final String PREFIX_KEY = "prefix";
public static final String BODY_KEY = "body";		public static final String BODY_KEY = "body";
public static final String MESSAGE_INFOS_KEY = "messageInfos";		public static final String MESSAGE_INFOS_KEY = "messageInfos";
public static final String THREAD_ID_KEY = "threadID";		public static final String THREAD_ID_KEY = "threadID";

public static final String TOKEN_EVENT = "TOKEN_EVENT";		public static final String TOKEN_EVENT = "TOKEN_EVENT";
public static final String MESSAGE_EVENT = "MESSAGE_EVENT";		public static final String MESSAGE_EVENT = "MESSAGE_EVENT";

@Override		@Override
public void onCreate() {		public void onCreate() {
super.onCreate();		super.onCreate();
CommSecureStore.getInstance().initialize(		CommSecureStore.getInstance().initialize(
ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext()));		ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext()));
notificationManager = (NotificationManager)this.getSystemService(		notificationManager = (NotificationManager)this.getSystemService(
Context.NOTIFICATION_SERVICE);		Context.NOTIFICATION_SERVICE);
localBroadcastManager = LocalBroadcastManager.getInstance(this);		localBroadcastManager = LocalBroadcastManager.getInstance(this);
displayableNotificationLargeIcon = BitmapFactory.decodeResource(		displayableNotificationLargeIcon = BitmapFactory.decodeResource(
this.getApplicationContext().getResources(), R.mipmap.ic_launcher);		this.getApplicationContext().getResources(), R.mipmap.ic_launcher);
blobClient = new CommAndroidBlobClient();		servicesClient = new CommAndroidServicesClient();
aesCryptoModule = new AESCryptoModuleCompat();		aesCryptoModule = new AESCryptoModuleCompat();
}		}

@Override		@Override
public void onNewToken(String token) {		public void onNewToken(String token) {
Intent intent = new Intent(TOKEN_EVENT);		Intent intent = new Intent(TOKEN_EVENT);
intent.putExtra("token", token);		intent.putExtra("token", token);
localBroadcastManager.sendBroadcast(intent);		localBroadcastManager.sendBroadcast(intent);
▲ Show 20 Lines • Show All 220 Lines • ▼ Show 20 Lines	if (rawMessageInfosString != null && sqliteFile.exists()) {
Log.w("COMM", "Database not existing yet. Skipping notification");		Log.w("COMM", "Database not existing yet. Skipping notification");
}		}
}		}

private void handleLargeNotification(RemoteMessage message) {		private void handleLargeNotification(RemoteMessage message) {
String blobHash = message.getData().get(BLOB_HASH_KEY);		String blobHash = message.getData().get(BLOB_HASH_KEY);
String blobHolder = message.getData().get(BLOB_HOLDER_KEY);		String blobHolder = message.getData().get(BLOB_HOLDER_KEY);
try {		try {
byte[] largePayload = blobClient.getBlobSync(blobHash);		byte[] largePayload = servicesClient.getBlobSync(blobHash);
message = aesDecryptRemoteMessage(message, largePayload);		message = aesDecryptRemoteMessage(message, largePayload);
handleMessageInfosPersistence(message);		handleMessageInfosPersistence(message);
} catch (Exception e) {		} catch (Exception e) {
Log.w("COMM", "Failure when handling large notification.", e);		Log.w("COMM", "Failure when handling large notification.", e);
}		}
blobClient.scheduleDeferredBlobDeletion(		servicesClient.scheduleDeferredBlobDeletion(
blobHash, blobHolder, this.getApplicationContext());		blobHash, blobHolder, this.getApplicationContext());
}		}

private void addToThreadGroupAndDisplay(		private void addToThreadGroupAndDisplay(
String notificationID,		String notificationID,
NotificationCompat.Builder notificationBuilder,		NotificationCompat.Builder notificationBuilder,
String threadID) {		String threadID) {

▲ Show 20 Lines • Show All 304 Lines • Show Last 20 Lines

[native] use identityGenerateNonce in SIWEPanel componentClosedPublicActions