[native] use identityGenerateNonce in SIWEPanel component
ClosedPublic
Actions

Authored by varun on Jan 30 2024, 8:25 PM.

Details

Reviewers

ashoat
inka

Commits

Summary

NOTE: SIWE won't work yet if usingCommServicesAccessToken is enabled.

This change just sets the nonce state variable to the value received from the identity service

Depends on D10880

Test Plan

logged the nonce and confirmed that the state variable was set successfully

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

varun requested review of this revision.Jan 30 2024, 8:43 PM

tomek requested changes to this revision.Jan 31 2024, 1:28 AM

tomek added inline comments.

native/account/siwe-panel.react.js
89–106 ↗	(On Diff #36364)	This shouldn't work and the test plan should fail in this case, so I'm a little surprised. We don't await a promise passed to `dispatchActionPromise` which makes it possible that `setNonce` will be called without `response` being set. The `setNonce` call should be kept inside the promises, just like it was before this diff.

This revision now requires changes to proceed.Jan 31 2024, 1:28 AM

ashoat added inline comments.

native/account/siwe-panel.react.js
64–66 ↗	(On Diff #36364)	Doesn't this need to be modified for your new action type?

address feedback

native/account/siwe-panel.react.js
64–66 ↗	(On Diff #36364)	yes, was going to be the next diff but makes more sense in this one
89–106 ↗	(On Diff #36364)	you're right, i was logging `response` inside the promise passed to `dispatchActionPromise`, not the `nonce` state variable