Page MenuHomePhabricator
Differential D10926

[web] refactor set new session in `redux-setup` to ops
ClosedPublic
Actions

Authored by kamil on Feb 1 2024, 5:38 PM.
Tags
None
Referenced Files
F3276047: D10926.diff
Sat, Nov 16, 7:18 AM
Unknown Object (File)
Tue, Nov 12, 5:35 PM
Unknown Object (File)
Wed, Nov 6, 8:05 PM
Unknown Object (File)
Oct 15 2024, 12:01 PM
Unknown Object (File)
Oct 15 2024, 12:01 PM
Unknown Object (File)
Oct 15 2024, 12:00 PM
Unknown Object (File)
Oct 15 2024, 12:00 PM
Unknown Object (File)
Sep 28 2024, 3:22 PM
View All 47 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMM4fa3ac20d292: [web] refactor set new session in `redux-setup` to ops
Summary

Convert logic to ops approach.

Depends on D10925

Test Plan

refresh web app

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Feb 1 2024, 5:38 PM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 1 2024, 5:38 PM
Harbormaster completed remote builds in B26447: Diff 36565.Feb 1 2024, 5:56 PM
kamil added a child revision: D10785: [native][web] start processing keyserver store ops on SQLite.Feb 1 2024, 6:00 PM
kamil published this revision for review.Feb 2 2024, 3:28 AM
kamil added inline comments.
web/redux/redux-setup.js
238 ↗(On Diff #36565)

ops are added to storeOperations in D10785

ashoat added a comment.Feb 2 2024, 7:50 AM

Strange that diffs that appear to depend on this one are already landed, before this one. Will this present any issues on master? Does it block release?

kamil added a comment.Feb 2 2024, 8:04 AM
In D10926#315341, @ashoat wrote:

Strange that diffs that appear to depend on this one are already landed, before this one.

D10785 and D10787 depend on this one - those are still in review.

Will this present any issues on master? Does it block release?

No, it's just a refactor - logic is the same.

inka accepted this revision.Feb 5 2024, 2:28 AM
This revision is now accepted and ready to land.Feb 5 2024, 2:28 AM
Closed by commit rCOMM4fa3ac20d292: [web] refactor set new session in `redux-setup` to ops (authored by kamil). · Explain WhyFeb 5 2024, 10:11 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM4fa3ac20d292: [web] refactor set new session in `redux-setup` to ops.

Revision Contents
Changeset List

PathSize
web/
redux/
21 lines

Diff 36630

View Options

web/redux/redux-setup.js

Loading...