Paths

Table of Contentst

Differential D11036

[lib] introduce barebones community types
ClosedPublic
Actions

Authored by ginsu on Feb 12 2024, 2:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 27, 4:41 AM

	Unknown Object (File)
	Tue, Nov 26, 11:40 PM

	Unknown Object (File)
	Thu, Nov 7, 11:27 PM

	Unknown Object (File)
	Wed, Nov 6, 3:24 PM

	Unknown Object (File)
	Oct 14 2024, 7:05 PM

	Unknown Object (File)
	Oct 14 2024, 7:05 PM

	Unknown Object (File)
	Oct 14 2024, 7:05 PM

	Unknown Object (File)
	Oct 14 2024, 7:04 PM

View All 57 Files

Subscribers

Details

Reviewers

atul
kamil
inka

Commits

rCOMM787d2ea5043e: [lib] introduce barebones community types

Summary

This diff introduces the barebones community types that will be used to build the community store. To keep things as simple as possible, I am just includinng the enabledApps since this will be needed for the web app redesign; however, I can imagine us wanting to extend this in the future when we build more community based features out

Linear task: https://linear.app/comm/issue/ENG-6157/introduce-community-types

Test Plan

flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Feb 12 2024, 2:24 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 12 2024, 2:24 AM

ginsu edited the summary of this revision. (Show Details)Feb 12 2024, 2:26 AM

ginsu added reviewers: atul, kamil, inka.

Harbormaster completed remote builds in B26751: Diff 36989.Feb 12 2024, 2:39 AM

ginsu requested review of this revision.Feb 12 2024, 2:39 AM

atul accepted this revision.Feb 12 2024, 1:07 PM

atul added inline comments.

lib/types/community-types.js
9 ↗	(On Diff #36989)	Instead of `key` can you do `threadID` to avoid including this comment? Something like:

This revision is now accepted and ready to land.Feb 12 2024, 1:07 PM

atul attached a referenced file: F1147415: 960170.png. (Show Details)Feb 12 2024, 1:10 PM

address feedback

This revision was landed with ongoing or failed builds.Feb 13 2024, 11:20 AM

Closed by commit rCOMM787d2ea5043e: [lib] introduce barebones community types (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM787d2ea5043e: [lib] introduce barebones community types.

Harbormaster completed remote builds in B26795: Diff 37035.Feb 13 2024, 11:35 AM

ginsu added a child revision: D11070: [lib] introduce CommunityStore spec.Feb 14 2024, 12:15 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

community-types.js

13 lines

Diff 37035

lib/types/community-types.js

Loading...