Page MenuHomePhabricator
Differential D11087

[sqlite] add communites table for community store data
ClosedPublic
Actions

Authored by ginsu on Feb 14 2024, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 12:09 AM
Unknown Object (File)
Thu, Nov 14, 12:08 AM
Unknown Object (File)
Thu, Nov 14, 12:08 AM
Unknown Object (File)
Thu, Nov 14, 12:08 AM
Unknown Object (File)
Thu, Nov 14, 12:08 AM
Unknown Object (File)
Wed, Nov 6, 3:24 PM
Unknown Object (File)
Fri, Nov 1, 4:37 AM
Unknown Object (File)
Fri, Nov 1, 4:37 AM
View All 49 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
kamil
Commits
rCOMM5d3f1a74764f: [sqlite] add communites table for community store data
Summary

Introduce migrations + modified initial create_schema sql query to introduce communities table to store community store data in SQLite

Depends on D11070

Test Plan

Test migration with new user and preexisting user and was able to see communities table

Screenshot 2024-02-15 at 5.04.59 PM.png (2×3 px, 994 KB)

Web logs showing we are on db version 35:

Screenshot 2024-02-16 at 3.39.19 PM.png (1×1 px, 444 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-5923 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 14 2024, 6:55 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 14 2024, 6:55 PM
ginsu retitled this revision from [sqlite] add communites table for community store data to DRAFT [sqlite] add communites table for community store data.Feb 14 2024, 6:57 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, kamil.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 14 2024, 7:06 PM
Harbormaster failed remote builds in B26847: Diff 37111!
ginsu updated this revision to Diff 37112.Feb 14 2024, 7:13 PM

update

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 14 2024, 7:24 PM
Harbormaster failed remote builds in B26848: Diff 37112!
ginsu updated this revision to Diff 37285.Feb 15 2024, 2:12 PM

rebase

ginsu retitled this revision from DRAFT [sqlite] add communites table for community store data to [sqlite] add communites table for community store data.Feb 15 2024, 2:16 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added a parent revision: D11070: [lib] introduce CommunityStore spec.
Harbormaster completed remote builds in B26943: Diff 37285.Feb 15 2024, 2:28 PM
ginsu requested review of this revision.Feb 15 2024, 2:28 PM
kamil accepted this revision.Feb 16 2024, 7:05 AM

Looks good, two nits:

  1. The file from the test plan is not visible
  2. Can you also check if it works on the web? Logs on the worker are enough - here is how you can access them
This revision is now accepted and ready to land.Feb 16 2024, 7:05 AM
ginsu attached a referenced file: F1164684: Screenshot 2024-02-15 at 5.04.59 PM.png. (Show Details)Feb 16 2024, 12:30 PM
ginsu edited the test plan for this revision. (Show Details)Feb 16 2024, 12:40 PM
ginsu attached a referenced file: F1166566: Screenshot 2024-02-16 at 3.39.19 PM.png. (Show Details)
In D11087#320698, @kamil wrote:

Looks good, two nits:

  1. The file from the test plan is not visible
  2. Can you also check if it works on the web? Logs on the worker are enough - here is how you can access them

Updated test plan!

kamil added a comment.Feb 20 2024, 6:46 AM

@ginsu I see you attached .wasm file so it's probably okay but it would be safer if you could wait with landing until resolving ENG-6879.

ginsu updated this revision to Diff 37458.Feb 22 2024, 2:06 PM

fix merge conflict with .wasm file

Harbormaster completed remote builds in B27077: Diff 37458.Feb 22 2024, 2:21 PM
ginsu added a child revision: D11151: [sqlite] add methods to operate on communities table.Feb 23 2024, 12:00 AM
kamil added a comment.Feb 27 2024, 1:20 AM
In D11087#321178, @kamil wrote:

@ginsu I see you attached .wasm file so it's probably okay but it would be safer if you could wait with landing until resolving ENG-6879.

Issue is fixed - you can rebase and should be fine to land

ginsu updated this revision to Diff 37666.Feb 27 2024, 7:17 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 27 2024, 8:02 PM
Closed by commit rCOMM5d3f1a74764f: [sqlite] add communites table for community store data (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5d3f1a74764f: [sqlite] add communites table for community store data.
Harbormaster failed remote builds in B27213: Diff 37666!Feb 28 2024, 1:37 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
17 lines

Diff 37111

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...