Page MenuHomePhabricator
Differential D11165

[lib] introduce addCommunityActionType
ClosedPublic
Actions

Authored by ginsu on Feb 25 2024, 11:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 7:17 AM
Unknown Object (File)
Thu, Apr 17, 5:58 AM
Unknown Object (File)
Thu, Apr 17, 2:03 AM
Unknown Object (File)
Wed, Apr 16, 10:38 PM
Unknown Object (File)
Wed, Apr 16, 10:20 AM
Unknown Object (File)
Wed, Apr 9, 9:20 PM
Unknown Object (File)
Tue, Apr 8, 10:00 PM
Unknown Object (File)
Tue, Apr 8, 10:00 PM
View All 95 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
kamil
Commits
rCOMM1ee876eefe7e: [lib] introduce addCommunityActionType
Summary

This diff introduces the addCommunityActionType which will be used in the community reducer

Linear task: https://linear.app/comm/issue/ENG-6578/introduce-add-a-community-to-the-community-store-action

Depends on D11164

Test Plan

flow + functionality will be tested in very next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 25 2024, 11:53 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 25 2024, 11:53 PM
ginsu edited the summary of this revision. (Show Details)Feb 25 2024, 11:55 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, kamil.
ginsu added a parent revision: D11164: [sqlite] implement processing community store ops on worker.
ginsu edited the test plan for this revision. (Show Details)Feb 26 2024, 12:00 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 26 2024, 12:04 AM
Harbormaster failed remote builds in B27153: Diff 37573!
ginsu added a child revision: D11166: [lib] introduce community reducer.Feb 26 2024, 12:04 AM
ginsu requested review of this revision.Feb 26 2024, 1:08 AM

will make sure ci passes before landing

atul accepted this revision.Feb 26 2024, 2:12 PM
This revision is now accepted and ready to land.Feb 26 2024, 2:12 PM
Harbormaster completed remote builds in B27153: Diff 37573.Feb 26 2024, 3:04 PM
kamil accepted this revision.Feb 27 2024, 1:23 AM
ginsu updated this revision to Diff 37672.Feb 27 2024, 7:40 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 27 2024, 8:02 PM
Closed by commit rCOMM1ee876eefe7e: [lib] introduce addCommunityActionType (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1ee876eefe7e: [lib] introduce addCommunityActionType.
Harbormaster failed remote builds in B27219: Diff 37672!Feb 27 2024, 8:03 PM

Revision Contents
Changeset List

PathSize
lib/
actions/
18 lines
types/
5 lines
5 lines

Diff 37573

View Options

lib/actions/community-actions.js

#pragma once #pragma once
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <mutex>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
enum class ReactorState { enum class ReactorState {
NONE = 0, NONE = 0,
RUNNING = 1, RUNNING = 1,
TERMINATED = 2, TERMINATED = 2,
DONE = 3, DONE = 3,
}; };
class BaseReactor { class BaseReactor {
private:
grpc::Status status = grpc::Status::OK;
std::mutex statusAccessMutex;
protected: protected:
ReactorState state = ReactorState::NONE; ReactorState state = ReactorState::NONE;
public: public:
grpc::Status getStatus() {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
return this->status;
}
void setStatus(const grpc::Status &status) {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
this->status = status;
}
ReactorState getState() const { ReactorState getState() const {
return this->state; return this->state;
} }
virtual void terminate(const grpc::Status &status){}; virtual void terminate(const grpc::Status &status){};
virtual void validate(){}; virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

lib/types/community-types.js

#pragma once #pragma once
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <mutex>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
enum class ReactorState { enum class ReactorState {
NONE = 0, NONE = 0,
RUNNING = 1, RUNNING = 1,
TERMINATED = 2, TERMINATED = 2,
DONE = 3, DONE = 3,
}; };
class BaseReactor { class BaseReactor {
private:
grpc::Status status = grpc::Status::OK;
std::mutex statusAccessMutex;
protected: protected:
ReactorState state = ReactorState::NONE; ReactorState state = ReactorState::NONE;
public: public:
grpc::Status getStatus() {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
return this->status;
}
void setStatus(const grpc::Status &status) {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
this->status = status;
}
ReactorState getState() const { ReactorState getState() const {
return this->state; return this->state;
} }
virtual void terminate(const grpc::Status &status){}; virtual void terminate(const grpc::Status &status){};
virtual void validate(){}; virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

lib/types/redux-types.js

#pragma once #pragma once
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <mutex>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
enum class ReactorState { enum class ReactorState {
NONE = 0, NONE = 0,
RUNNING = 1, RUNNING = 1,
TERMINATED = 2, TERMINATED = 2,
DONE = 3, DONE = 3,
}; };
class BaseReactor { class BaseReactor {
private:
grpc::Status status = grpc::Status::OK;
std::mutex statusAccessMutex;
protected: protected:
ReactorState state = ReactorState::NONE; ReactorState state = ReactorState::NONE;
public: public:
grpc::Status getStatus() {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
return this->status;
}
void setStatus(const grpc::Status &status) {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
this->status = status;
}
ReactorState getState() const { ReactorState getState() const {
return this->state; return this->state;
} }
virtual void terminate(const grpc::Status &status){}; virtual void terminate(const grpc::Status &status){};
virtual void validate(){}; virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm