Page MenuHomePhabricator
Differential D11733

Update latest backup id search index to include 'msgBackup'
ClosedPublic
Actions

Authored by marcin on Tue, Apr 23, 3:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 7:59 AM
Unknown Object (File)
Tue, Apr 30, 11:54 AM
Unknown Object (File)
Sun, Apr 28, 2:30 PM
Unknown Object (File)
Fri, Apr 26, 2:30 PM
Unknown Object (File)
Tue, Apr 23, 9:18 PM
Unknown Object (File)
Tue, Apr 23, 9:18 PM
Unknown Object (File)
Tue, Apr 23, 9:17 PM
Subscribers
ashoat
tomek

Details

Reviewers
bartek
kamil
Commits
rCOMMb5133e10780b: Update latest backup id search index to include 'msgBackup'
Summary

This differential updatest backup table dynamodb schema. Without this change I was unable to get backup messages from dynamodb back even though I was able to put them
in the db. My understanding is that when fetching latest backup item we use index that previously wasn't aware of msg_backup field.

Test Plan

run terraform fmt and validate.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Tue, Apr 23, 3:48 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Apr 23, 3:48 AM
marcin added a parent revision: D11716: Enable backup creation and upload for SIWE users from JS.Tue, Apr 23, 3:49 AM
marcin added a child revision: D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.Tue, Apr 23, 3:52 AM
Harbormaster completed remote builds in B28395: Diff 39390.Tue, Apr 23, 4:04 AM
marcin requested review of this revision.Tue, Apr 23, 4:04 AM
bartek accepted this revision.Wed, Apr 24, 2:00 AM

Looks good, let me know when you'll be landing this, so we can do terraform apply together

services/terraform/modules/shared/dynamodb.tf
27

Technically doesn't matter, but consider my comment in https://phab.comm.dev/D11713#inline-70321

This revision is now accepted and ready to land.Wed, Apr 24, 2:00 AM
marcin updated this revision to Diff 39540.Fri, Apr 26, 6:24 AM

Rename msgBackup to siweBackupMsg

Harbormaster completed remote builds in B28505: Diff 39540.Fri, Apr 26, 6:50 AM
marcin updated this revision to Diff 40002.Thu, May 9, 6:20 AM

Rebase before landing

Harbormaster completed remote builds in B28801: Diff 40002.Thu, May 9, 6:45 AM
Closed by commit rCOMMb5133e10780b: Update latest backup id search index to include 'msgBackup' (authored by marcin). · Explain WhyThu, May 9, 7:00 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMb5133e10780b: Update latest backup id search index to include 'msgBackup'.

Revision Contents
Changeset List

PathSize
services/
terraform/
modules/
shared/
2 lines

Diff 39390

View Options

services/terraform/modules/shared/dynamodb.tf

Loading...