Details
flow/CI/etc.
Thread where I shouldn't have EDIT_THREAD_AVATAR permission doesn't let me change avatar:
Thread where I should have EDIT_THREAD_AVATAR permission DOES let me change avatar:
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I was going to do one big diff that updated everything in web, then native, etc... but there are some slight additional changes being made to these components (changing of Prop types, dep lists, etc) so figured it might be safe to break each into a separate diff even if it's spammy? Can change approach if preferred, but going off feedback from https://phab.comm.dev/D9907
I think you should consider having a test plan that actually verifies that this logic is correct.
Added Test Plan for this diff and did some console logging as sanity check for subsequent diffs, but think it's unnecessary to do a full blown Test Plan for diffs in this stack since changes are pretty straightforward