Paths

Table of Contentst

-
keyserver/src/socket/
-
src/
-
socket/
-
tunnelbroker-socket.js
-
lib/
-
tunnelbroker/
-
tunnelbroker-context.js
-
utils/
-
crypto-utils.js
-
web/settings/
-
settings/
-
tunnelbroker-test.react.js

Differential D12045

[lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to `TunnelbrokerClientMessageToDevice`
ClosedPublic
Actions

Authored by kamil on May 15 2024, 1:46 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMM6de8fd7938d1: [lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to…

Summary

There are multiple ClientMessageToDevice and other *MessageToDevice types which makes it confusing and not really readable - renaming to make it more specific.

Depends on D12044

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 15 2024, 1:46 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 15 2024, 1:46 AM

Harbormaster completed remote builds in B28931: Diff 40205.May 15 2024, 2:06 AM

kamil added a child revision: D12046: [lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage`.May 15 2024, 2:07 AM

kamil published this revision for review.May 16 2024, 1:34 AM

bartek accepted this revision.May 16 2024, 7:12 AM

This revision is now accepted and ready to land.May 16 2024, 7:12 AM

Closed by commit rCOMM6de8fd7938d1: [lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to… (authored by kamil). · Explain WhyMay 16 2024, 10:22 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM6de8fd7938d1: [lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

tunnelbroker-socket.js

6 lines

lib/

tunnelbroker/

tunnelbroker-context.js

35 lines

utils/

crypto-utils.js

4 lines

web/

settings/

tunnelbroker-test.react.js

4 lines

Diff 40301

View Options

keyserver/src/socket/tunnelbroker-socket.js

	Show All 13 Lines
	import type { ClientReportCreationRequest } from './report-types.js';			import type { ClientReportCreationRequest } from './report-types.js';
	import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';			import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';
	import type { UserInfos } from './user-types.js';			import type { UserInfos } from './user-types.js';
	import type {			import type {
	ClientDBCommunityInfo,			ClientDBCommunityInfo,
	ClientDBCommunityStoreOperation,			ClientDBCommunityStoreOperation,
	CommunityStoreOperation,			CommunityStoreOperation,
	} from '../ops/community-store-ops.js';			} from '../ops/community-store-ops.js';
	import type { ClientDBIntegrityThreadHash } from '../ops/integrity-store-ops.js';			import type {
				ClientDBIntegrityThreadHash,
				ClientDBIntegrityStoreOperation,
				} from '../ops/integrity-store-ops.js';
	import type {			import type {
	ClientDBKeyserverInfo,			ClientDBKeyserverInfo,
	ClientDBKeyserverStoreOperation,			ClientDBKeyserverStoreOperation,
	KeyserverStoreOperation,			KeyserverStoreOperation,
	} from '../ops/keyserver-store-ops.js';			} from '../ops/keyserver-store-ops.js';
	import type {			import type {
	ClientDBMessageStoreOperation,			ClientDBMessageStoreOperation,
	MessageStoreOperation,			MessageStoreOperation,
	Show All 24 Lines

	export type ClientDBStoreOperations = {			export type ClientDBStoreOperations = {
	+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,			+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,
	+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,			+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,
	+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,			+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,
	+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,			+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,
	+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,			+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,
	+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,			+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,
				+integrityStoreOperations?: $ReadOnlyArray<ClientDBIntegrityStoreOperation>,
	};			};

	export type ClientDBStore = {			export type ClientDBStore = {
	+messages: $ReadOnlyArray<ClientDBMessageInfo>,			+messages: $ReadOnlyArray<ClientDBMessageInfo>,
	+drafts: $ReadOnlyArray<ClientDBDraftInfo>,			+drafts: $ReadOnlyArray<ClientDBDraftInfo>,
	+threads: $ReadOnlyArray<ClientDBThreadInfo>,			+threads: $ReadOnlyArray<ClientDBThreadInfo>,
	+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,			+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
	+reports: $ReadOnlyArray<ClientDBReport>,			+reports: $ReadOnlyArray<ClientDBReport>,
	Show All 17 Lines

View Options

lib/tunnelbroker/tunnelbroker-context.js

	Show All 13 Lines
	import type { ClientReportCreationRequest } from './report-types.js';			import type { ClientReportCreationRequest } from './report-types.js';
	import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';			import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';
	import type { UserInfos } from './user-types.js';			import type { UserInfos } from './user-types.js';
	import type {			import type {
	ClientDBCommunityInfo,			ClientDBCommunityInfo,
	ClientDBCommunityStoreOperation,			ClientDBCommunityStoreOperation,
	CommunityStoreOperation,			CommunityStoreOperation,
	} from '../ops/community-store-ops.js';			} from '../ops/community-store-ops.js';
	import type { ClientDBIntegrityThreadHash } from '../ops/integrity-store-ops.js';			import type {
				ClientDBIntegrityThreadHash,
				ClientDBIntegrityStoreOperation,
				} from '../ops/integrity-store-ops.js';
	import type {			import type {
	ClientDBKeyserverInfo,			ClientDBKeyserverInfo,
	ClientDBKeyserverStoreOperation,			ClientDBKeyserverStoreOperation,
	KeyserverStoreOperation,			KeyserverStoreOperation,
	} from '../ops/keyserver-store-ops.js';			} from '../ops/keyserver-store-ops.js';
	import type {			import type {
	ClientDBMessageStoreOperation,			ClientDBMessageStoreOperation,
	MessageStoreOperation,			MessageStoreOperation,
	Show All 24 Lines

	export type ClientDBStoreOperations = {			export type ClientDBStoreOperations = {
	+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,			+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,
	+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,			+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,
	+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,			+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,
	+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,			+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,
	+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,			+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,
	+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,			+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,
				+integrityStoreOperations?: $ReadOnlyArray<ClientDBIntegrityStoreOperation>,
	};			};

	export type ClientDBStore = {			export type ClientDBStore = {
	+messages: $ReadOnlyArray<ClientDBMessageInfo>,			+messages: $ReadOnlyArray<ClientDBMessageInfo>,
	+drafts: $ReadOnlyArray<ClientDBDraftInfo>,			+drafts: $ReadOnlyArray<ClientDBDraftInfo>,
	+threads: $ReadOnlyArray<ClientDBThreadInfo>,			+threads: $ReadOnlyArray<ClientDBThreadInfo>,
	+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,			+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
	+reports: $ReadOnlyArray<ClientDBReport>,			+reports: $ReadOnlyArray<ClientDBReport>,
	Show All 17 Lines

View Options

lib/utils/crypto-utils.js

	Show All 13 Lines
	import type { ClientReportCreationRequest } from './report-types.js';			import type { ClientReportCreationRequest } from './report-types.js';
	import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';			import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';
	import type { UserInfos } from './user-types.js';			import type { UserInfos } from './user-types.js';
	import type {			import type {
	ClientDBCommunityInfo,			ClientDBCommunityInfo,
	ClientDBCommunityStoreOperation,			ClientDBCommunityStoreOperation,
	CommunityStoreOperation,			CommunityStoreOperation,
	} from '../ops/community-store-ops.js';			} from '../ops/community-store-ops.js';
	import type { ClientDBIntegrityThreadHash } from '../ops/integrity-store-ops.js';			import type {
				ClientDBIntegrityThreadHash,
				ClientDBIntegrityStoreOperation,
				} from '../ops/integrity-store-ops.js';
	import type {			import type {
	ClientDBKeyserverInfo,			ClientDBKeyserverInfo,
	ClientDBKeyserverStoreOperation,			ClientDBKeyserverStoreOperation,
	KeyserverStoreOperation,			KeyserverStoreOperation,
	} from '../ops/keyserver-store-ops.js';			} from '../ops/keyserver-store-ops.js';
	import type {			import type {
	ClientDBMessageStoreOperation,			ClientDBMessageStoreOperation,
	MessageStoreOperation,			MessageStoreOperation,
	Show All 24 Lines

	export type ClientDBStoreOperations = {			export type ClientDBStoreOperations = {
	+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,			+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,
	+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,			+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,
	+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,			+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,
	+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,			+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,
	+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,			+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,
	+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,			+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,
				+integrityStoreOperations?: $ReadOnlyArray<ClientDBIntegrityStoreOperation>,
	};			};

	export type ClientDBStore = {			export type ClientDBStore = {
	+messages: $ReadOnlyArray<ClientDBMessageInfo>,			+messages: $ReadOnlyArray<ClientDBMessageInfo>,
	+drafts: $ReadOnlyArray<ClientDBDraftInfo>,			+drafts: $ReadOnlyArray<ClientDBDraftInfo>,
	+threads: $ReadOnlyArray<ClientDBThreadInfo>,			+threads: $ReadOnlyArray<ClientDBThreadInfo>,
	+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,			+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
	+reports: $ReadOnlyArray<ClientDBReport>,			+reports: $ReadOnlyArray<ClientDBReport>,
	Show All 17 Lines

View Options

web/settings/tunnelbroker-test.react.js

	Show All 13 Lines
	import type { ClientReportCreationRequest } from './report-types.js';			import type { ClientReportCreationRequest } from './report-types.js';
	import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';			import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';
	import type { UserInfos } from './user-types.js';			import type { UserInfos } from './user-types.js';
	import type {			import type {
	ClientDBCommunityInfo,			ClientDBCommunityInfo,
	ClientDBCommunityStoreOperation,			ClientDBCommunityStoreOperation,
	CommunityStoreOperation,			CommunityStoreOperation,
	} from '../ops/community-store-ops.js';			} from '../ops/community-store-ops.js';
	import type { ClientDBIntegrityThreadHash } from '../ops/integrity-store-ops.js';			import type {
				ClientDBIntegrityThreadHash,
				ClientDBIntegrityStoreOperation,
				} from '../ops/integrity-store-ops.js';
	import type {			import type {
	ClientDBKeyserverInfo,			ClientDBKeyserverInfo,
	ClientDBKeyserverStoreOperation,			ClientDBKeyserverStoreOperation,
	KeyserverStoreOperation,			KeyserverStoreOperation,
	} from '../ops/keyserver-store-ops.js';			} from '../ops/keyserver-store-ops.js';
	import type {			import type {
	ClientDBMessageStoreOperation,			ClientDBMessageStoreOperation,
	MessageStoreOperation,			MessageStoreOperation,
	Show All 24 Lines

	export type ClientDBStoreOperations = {			export type ClientDBStoreOperations = {
	+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,			+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,
	+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,			+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,
	+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,			+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,
	+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,			+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,
	+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,			+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,
	+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,			+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,
				+integrityStoreOperations?: $ReadOnlyArray<ClientDBIntegrityStoreOperation>,
	};			};

	export type ClientDBStore = {			export type ClientDBStore = {
	+messages: $ReadOnlyArray<ClientDBMessageInfo>,			+messages: $ReadOnlyArray<ClientDBMessageInfo>,
	+drafts: $ReadOnlyArray<ClientDBDraftInfo>,			+drafts: $ReadOnlyArray<ClientDBDraftInfo>,
	+threads: $ReadOnlyArray<ClientDBThreadInfo>,			+threads: $ReadOnlyArray<ClientDBThreadInfo>,
	+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,			+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
	+reports: $ReadOnlyArray<ClientDBReport>,			+reports: $ReadOnlyArray<ClientDBReport>,
	Show All 17 Lines

[lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to `TunnelbrokerClientMessageToDevice`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40301

keyserver/src/socket/tunnelbroker-socket.js

lib/tunnelbroker/tunnelbroker-context.js

lib/utils/crypto-utils.js

web/settings/tunnelbroker-test.react.js

[lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to `TunnelbrokerClientMessageToDevice`
ClosedPublic
Actions

Revision Contents
Changeset List