Paths

Table of Contentst

-
lib/
-
handlers/
-
db-ops-handler.react.js
-
types/
-
sqlite-types.js
-
utils/__mocks__/
-
__mocks__/
-
config.js
-
native/
-
cpp/CommonCpp/
-
CommonCpp/
-
DatabaseManagers/
-
DatabaseQueryExecutor.h
-
SQLiteQueryExecutor.h
-
SQLiteQueryExecutor.cpp
-
entities/
-
InboundP2PMessage.h
-
ReceivedMessageToDevice.h
-
NativeModules/
-
CommCoreModule.h
-
CommCoreModule.cpp
-
_generated/
-
commJSI-generated.cpp
-
commJSI.h
-
database/
-
sqlite-api.js
-
schema/
-
CommCoreModuleSchema.js
-
web/
-
cpp/
-
SQLiteQueryExecutorBindings.cpp
-
database/
-
sqlite-api.js
-
shared-worker/
-
_generated/
-
comm_query_executor.wasm
-
queries/
-
inbound-p2p-message-queries.test.js
-
received-messages-to-device-queries.test.js
-
types/
-
sqlite-query-executor.js
-
worker/
-
shared-worker.js
-
worker-crypto.js
-
types/
-
worker-types.js

Differential D12046

[lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage`
ClosedPublic
Actions

Authored by kamil on May 15 2024, 2:07 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMMba5f1b8f468d: [lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage`

Summary

ReceivedMessageToDevice is confusing and does not reflect its purpose.
Renaming to InboundP2PMessage.
Renaming MessageToDevice -> OutboundP2PMessage in next diff.

Depends on D12045

Test Plan

Flow & tests

Diff Detail

Repository

rCOMM Comm

Branch

publish-broadcasting

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 15 2024, 2:07 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 15 2024, 2:07 AM

Harbormaster completed remote builds in B28932: Diff 40206.May 15 2024, 2:24 AM

kamil added a child revision: D12047: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage`.May 15 2024, 3:56 AM

kamil published this revision for review.May 16 2024, 1:34 AM

bartek accepted this revision.May 16 2024, 7:13 AM

This revision is now accepted and ready to land.May 16 2024, 7:13 AM

Closed by commit rCOMMba5f1b8f468d: [lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage` (authored by kamil). · Explain WhyMay 16 2024, 10:22 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMba5f1b8f468d: [lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage`.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

db-ops-handler.react.js

2 lines

types/

sqlite-types.js

8 lines

utils/

__mocks__/

config.js

4 lines

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

10 lines

SQLiteQueryExecutor.h

8 lines

SQLiteQueryExecutor.cpp

14 lines

entities/

	InboundP2PMessage.h
	ReceivedMessageToDevice.h

6 lines

ReceivedMessageToDevice.h

NativeModules/

CommCoreModule.h

4 lines

CommCoreModule.cpp

28 lines

_generated/

commJSI-generated.cpp

commJSI.h

database/

sqlite-api.js

4 lines

schema/

CommCoreModuleSchema.js

8 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

23 lines

database/

sqlite-api.js

17 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

	inbound-p2p-message-queries.test.js
	received-messages-to-device-queries.test.js

22 lines

received-messages-to-device-queries.test.js

types/

sqlite-query-executor.js

8 lines

worker/

shared-worker.js

11 lines

worker-crypto.js

6 lines

types/

worker-types.js

24 lines

Diff 40206

View Options

lib/handlers/db-ops-handler.react.js

View Options

lib/types/sqlite-types.js

View Options

lib/utils/mocks/config.js

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/InboundP2PMessage.h

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/ReceivedMessageToDevice.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/database/sqlite-api.js

View Options

native/schema/CommCoreModuleSchema.js

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/database/sqlite-api.js

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/queries/inbound-p2p-message-queries.test.js

View Options

web/shared-worker/queries/received-messages-to-device-queries.test.js

View Options

web/shared-worker/types/sqlite-query-executor.js

View Options

web/shared-worker/worker/shared-worker.js

View Options

web/shared-worker/worker/worker-crypto.js

View Options

[lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40206

lib/handlers/db-ops-handler.react.js

lib/types/sqlite-types.js

lib/utils/__mocks__/config.js

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/InboundP2PMessage.h

native/cpp/CommonCpp/DatabaseManagers/entities/ReceivedMessageToDevice.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/database/sqlite-api.js

native/schema/CommCoreModuleSchema.js

web/cpp/SQLiteQueryExecutorBindings.cpp

web/database/sqlite-api.js

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/inbound-p2p-message-queries.test.js

web/shared-worker/queries/received-messages-to-device-queries.test.js

web/shared-worker/types/sqlite-query-executor.js

web/shared-worker/worker/shared-worker.js

web/shared-worker/worker/worker-crypto.js

web/types/worker-types.js

[lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage`
ClosedPublic
Actions

Revision Contents
Changeset List

lib/utils/mocks/config.js