Page MenuHomePhabricator
Differential D12049

[lib] Add a way of marking migrations as schema-changing
ClosedPublic
Actions

Authored by tomek on May 15 2024, 5:11 AM.
Tags
None
Referenced Files
F2147958: D12049.diff
Sun, Jun 30, 3:25 AM
Unknown Object (File)
Fri, Jun 28, 2:33 PM
Unknown Object (File)
Wed, Jun 19, 12:55 PM
Unknown Object (File)
Mon, Jun 17, 10:31 PM
Unknown Object (File)
Mon, Jun 17, 10:30 PM
Unknown Object (File)
Mon, Jun 17, 10:29 PM
Unknown Object (File)
Fri, Jun 14, 5:19 PM
Unknown Object (File)
Wed, Jun 12, 4:37 PM
View All 28 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
varun
Commits
rCOMMd6d8d733cb12: [lib] Add a way of marking migrations as schema-changing
Summary

When running the migrations check if any of them is marked as schema-changing.

https://linear.app/comm/issue/ENG-7493/add-a-way-of-marking-migrations-as-schema-changing

Depends on D12015

Test Plan

Add a log checking if schemaChanged is computed correctly. Add a migration without changesSchema and check if the value is false. Then add a migration that changesSchema and check if the value is true.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.May 15 2024, 5:11 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 15 2024, 5:12 AM
Harbormaster completed remote builds in B28935: Diff 40209.May 15 2024, 5:28 AM
tomek requested review of this revision.May 15 2024, 5:28 AM
tomek added a child revision: D12050: [lib] Create a compaction after schema-changing migration.May 15 2024, 5:49 AM
tomek updated this revision to Diff 40290.May 16 2024, 7:26 AM

Rebase

Harbormaster completed remote builds in B28986: Diff 40290.May 16 2024, 7:42 AM
marcin accepted this revision.May 17 2024, 3:15 AM
This revision is now accepted and ready to land.May 17 2024, 3:15 AM
tomek edited the summary of this revision. (Show Details)Mon, Jun 3, 8:46 AM
tomek added a parent revision: D12015: [lib] Extract a function that runs the migrations.
tomek removed a parent revision: D12048: [web] Run backup migrations.
tomek updated this revision to Diff 40885.Mon, Jun 3, 8:49 AM

Rebase

Harbormaster failed remote builds in B29386: Diff 40885!Mon, Jun 3, 9:32 AM
tomek updated this revision to Diff 40933.Tue, Jun 4, 3:21 AM

Rebase

Harbormaster completed remote builds in B29432: Diff 40933.Tue, Jun 4, 3:45 AM
Closed by commit rCOMMd6d8d733cb12: [lib] Add a way of marking migrations as schema-changing (authored by tomek). · Explain WhyTue, Jun 4, 5:45 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMd6d8d733cb12: [lib] Add a way of marking migrations as schema-changing.

Revision Contents
Changeset List

PathSize
lib/
utils/
76 lines

Diff 40951

View Options

lib/utils/migration-utils.js

Loading...