[lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`
ClosedPublic
Actions

Authored by atul on Mon, Jun 3, 2:00 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM67a5bdca2dc0: [lib] Remove `skipMemberAdminRoleCheck` option from…

Summary

Instead of having a boolean flag, we have a separate threadIsWithBlockedUserOnlyWithoutAdminRoleCheck function which skips the admin role check.

threadIsWithBlockedUserOnly takes LegacyRawThreadInfo | RawThreadInfo and goes through "traditional" admin role check
threadIsWithBlockedUserOnlyWithoutAdminRoleCheck takes only ThreadInfo and handles admin role check "before" via hook

Depends on D12293

Test Plan

flow + close reading

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D12294_1 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mon, Jun 3, 2:00 PM

atul published this revision for review.Mon, Jun 3, 2:04 PM

atul added a child revision: D12295: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of `baseThreadIsWithBlockedUserOnly[WithoutAdminRoleCheck]`.Mon, Jun 3, 2:10 PM

Harbormaster completed remote builds in B29402: Diff 40903.Mon, Jun 3, 2:16 PM

tomek accepted this revision.Tue, Jun 4, 1:58 AM

This revision is now accepted and ready to land.Tue, Jun 4, 1:58 AM

ashoat accepted this revision.Tue, Jun 4, 11:42 AM

land

Harbormaster completed remote builds in B29725: Diff 41416.Mon, Jun 17, 12:11 PM

Closed by commit rCOMM67a5bdca2dc0: [lib] Remove `skipMemberAdminRoleCheck` option from… (authored by atul). · Explain WhyMon, Jun 17, 1:45 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM67a5bdca2dc0: [lib] Remove `skipMemberAdminRoleCheck` option from….

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

17 lines

Diff 41416

View Options

lib/shared/thread-utils.js

[lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`ClosedPublicActions