Page MenuHomePhabricator

[lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`
ClosedPublic

Authored by atul on Jun 3 2024, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 4:46 AM
Unknown Object (File)
Sat, Mar 29, 9:46 PM
Unknown Object (File)
Fri, Mar 28, 8:34 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Subscribers
None

Details

Summary

Instead of having a boolean flag, we have a separate threadIsWithBlockedUserOnlyWithoutAdminRoleCheck function which skips the admin role check.

threadIsWithBlockedUserOnly takes LegacyRawThreadInfo | RawThreadInfo and goes through "traditional" admin role check
threadIsWithBlockedUserOnlyWithoutAdminRoleCheck takes only ThreadInfo and handles admin role check "before" via hook


Depends on D12293

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable