Paths

Table of Contentst

[commtest] Make ClientPublicKeys::device_id() return str slice
ClosedPublic
Actions

Authored by bartek on Jun 7 2024, 6:32 AM.

Details

Reviewers

kamil
will
varun
marcin

Commits

rCOMMca2f17d8813d: [commtest] Make ClientPublicKeys::device_id() return str slice

Summary

Depends on D12341

Minor change for better reusability. It's better to have a slice and use to_string() only when needed.

Test Plan

Commtest

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 7 2024, 6:32 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2024, 6:32 AM

bartek added a child revision: D12343: [commtest] Get rid of hardcoded ClientPublicKeys values.Jun 7 2024, 6:34 AM

Harbormaster failed remote builds in B29512: Diff 41085!Jun 7 2024, 6:37 AM

Rebase on flaky test fix

Harbormaster failed remote builds in B29526: Diff 41099!Jun 7 2024, 11:08 AM

bartek published this revision for review.Jun 7 2024, 11:20 AM

Harbormaster completed remote builds in B29526: Diff 41099.Jun 10 2024, 6:26 AM

kamil accepted this revision.Jun 10 2024, 5:13 PM

This revision is now accepted and ready to land.Jun 10 2024, 5:13 PM

Closed by commit rCOMMca2f17d8813d: [commtest] Make ClientPublicKeys::device_id() return str slice. · Explain WhyJun 12 2024, 2:31 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMca2f17d8813d: [commtest] Make ClientPublicKeys::device_id() return str slice.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

device.rs

4 lines

olm_account_infos.rs

4 lines

tests/

identity_device_list_tests.rs

10 lines

Diff 41099

View Options

services/commtest/src/identity/device.rs

View Options

services/commtest/src/identity/olm_account_infos.rs

View Options

services/commtest/tests/identity_device_list_tests.rs

[commtest] Make ClientPublicKeys::device_id() return str sliceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41099

services/commtest/src/identity/device.rs

services/commtest/src/identity/olm_account_infos.rs

services/commtest/tests/identity_device_list_tests.rs

[commtest] Make ClientPublicKeys::device_id() return str slice
ClosedPublic
Actions

Revision Contents
Changeset List