Page MenuHomePhabricator
Differential D12452

[native] update QR login flow to use `QRAuthContext`
ClosedPublic
Actions

Authored by kamil on Jun 17 2024, 4:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 3:35 AM
Unknown Object (File)
Tue, Nov 5, 3:32 AM
Unknown Object (File)
Tue, Nov 5, 1:25 AM
Unknown Object (File)
Fri, Nov 1, 1:47 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
View All 44 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMM831b3f2a9d91: [native] update QR login flow to use `QRAuthContext`
Summary

ENG-8385.

QR code login is not working right now. As described here (Point 3) and here the issue is occuring because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

Rendering context and de-duplicating logic.

Depends on D12450

Test Plan

Test QR login flow on native. Adding a bunch of logs to make sure it works and all messages are sent.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
qr-code/
58 lines
5 lines
132 lines

Diff 41500

View Options

native/qr-code/qr-code-screen.react.js

Loading...
View Options

native/qr-code/qr-code-utils.js

Loading...
View Options

native/root.react.js

Loading...