Page MenuHomePhabricator
Differential D12824

[keyserver][lib] Factor out joinThreadSubscription
ClosedPublic
Actions

Authored by ashoat on Jul 20 2024, 9:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 3:43 AM
Unknown Object (File)
Sat, Apr 19, 10:36 PM
Unknown Object (File)
Sat, Apr 19, 12:07 PM
Unknown Object (File)
Thu, Apr 17, 8:32 PM
Unknown Object (File)
Mar 15 2025, 9:47 AM
Unknown Object (File)
Mar 11 2025, 5:31 PM
Unknown Object (File)
Mar 5 2025, 4:38 PM
Unknown Object (File)
Mar 4 2025, 12:40 PM
View All 65 Files
Subscribers
None

Details

Reviewers
tomek
kamil
marcin
Commits
rCOMM82b5866a1c9a: [keyserver][lib] Factor out joinThreadSubscription
Summary

This diff does two minor things:

  1. Factors out joinThreadSubscription so it can be reused in the following diff
  2. Redefines defaultSubscriptionString so that it uses defaultThreadSubscription instead of redefining it

Depends on D12781

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
13 lines
lib/
types/
11 lines

Diff 42590

View Options

keyserver/src/updaters/thread-permission-updaters.js

Show All 13 Lines
import type { ClientReportCreationRequest } from './report-types.js'; import type { ClientReportCreationRequest } from './report-types.js';
import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js'; import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';
import type { UserInfos } from './user-types.js'; import type { UserInfos } from './user-types.js';
import type { import type {
ClientDBCommunityInfo, ClientDBCommunityInfo,
ClientDBCommunityStoreOperation, ClientDBCommunityStoreOperation,
CommunityStoreOperation, CommunityStoreOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { ClientDBIntegrityThreadHash } from '../ops/integrity-store-ops.js'; import type {
ClientDBIntegrityThreadHash,
ClientDBIntegrityStoreOperation,
} from '../ops/integrity-store-ops.js';
import type { import type {
ClientDBKeyserverInfo, ClientDBKeyserverInfo,
ClientDBKeyserverStoreOperation, ClientDBKeyserverStoreOperation,
KeyserverStoreOperation, KeyserverStoreOperation,
} from '../ops/keyserver-store-ops.js'; } from '../ops/keyserver-store-ops.js';
import type { import type {
ClientDBMessageStoreOperation, ClientDBMessageStoreOperation,
MessageStoreOperation, MessageStoreOperation,
Show All 24 Lines
export type ClientDBStoreOperations = { export type ClientDBStoreOperations = {
+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>, +draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,
+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>, +threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,
+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>, +messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,
+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>, +reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,
+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>, +keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,
+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>, +communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,
+integrityStoreOperations?: $ReadOnlyArray<ClientDBIntegrityStoreOperation>,
}; };
export type ClientDBStore = { export type ClientDBStore = {
+messages: $ReadOnlyArray<ClientDBMessageInfo>, +messages: $ReadOnlyArray<ClientDBMessageInfo>,
+drafts: $ReadOnlyArray<ClientDBDraftInfo>, +drafts: $ReadOnlyArray<ClientDBDraftInfo>,
+threads: $ReadOnlyArray<ClientDBThreadInfo>, +threads: $ReadOnlyArray<ClientDBThreadInfo>,
+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>, +messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
+reports: $ReadOnlyArray<ClientDBReport>, +reports: $ReadOnlyArray<ClientDBReport>,
Show All 17 Lines
View Options

lib/types/subscription-types.js

Show All 13 Lines
import type { ClientReportCreationRequest } from './report-types.js'; import type { ClientReportCreationRequest } from './report-types.js';
import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js'; import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';
import type { UserInfos } from './user-types.js'; import type { UserInfos } from './user-types.js';
import type { import type {
ClientDBCommunityInfo, ClientDBCommunityInfo,
ClientDBCommunityStoreOperation, ClientDBCommunityStoreOperation,
CommunityStoreOperation, CommunityStoreOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { ClientDBIntegrityThreadHash } from '../ops/integrity-store-ops.js'; import type {
ClientDBIntegrityThreadHash,
ClientDBIntegrityStoreOperation,
} from '../ops/integrity-store-ops.js';
import type { import type {
ClientDBKeyserverInfo, ClientDBKeyserverInfo,
ClientDBKeyserverStoreOperation, ClientDBKeyserverStoreOperation,
KeyserverStoreOperation, KeyserverStoreOperation,
} from '../ops/keyserver-store-ops.js'; } from '../ops/keyserver-store-ops.js';
import type { import type {
ClientDBMessageStoreOperation, ClientDBMessageStoreOperation,
MessageStoreOperation, MessageStoreOperation,
Show All 24 Lines
export type ClientDBStoreOperations = { export type ClientDBStoreOperations = {
+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>, +draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,
+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>, +threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,
+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>, +messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,
+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>, +reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,
+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>, +keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,
+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>, +communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,
+integrityStoreOperations?: $ReadOnlyArray<ClientDBIntegrityStoreOperation>,
}; };
export type ClientDBStore = { export type ClientDBStore = {
+messages: $ReadOnlyArray<ClientDBMessageInfo>, +messages: $ReadOnlyArray<ClientDBMessageInfo>,
+drafts: $ReadOnlyArray<ClientDBDraftInfo>, +drafts: $ReadOnlyArray<ClientDBDraftInfo>,
+threads: $ReadOnlyArray<ClientDBThreadInfo>, +threads: $ReadOnlyArray<ClientDBThreadInfo>,
+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>, +messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
+reports: $ReadOnlyArray<ClientDBReport>, +reports: $ReadOnlyArray<ClientDBReport>,
Show All 17 Lines