[SQLite] deprecate `removeOutboundP2PMessagesOlderThan` and update to remove only one specific message
ClosedPublic
Actions

Authored by kamil on Aug 14 2024, 7:01 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMM74b74fdfee46: [SQLite] deprecate `removeOutboundP2PMessagesOlderThan` and update to remove…

Summary

ENG-8994.

This difference includes two things:

Update to the query
Rename

Test Plan

Tests

Diff Detail

Repository

rCOMM Comm

Branch

land

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 14 2024, 7:01 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 14 2024, 7:01 AM

kamil published this revision for review.Aug 14 2024, 7:03 AM

kamil edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B31100: Diff 43386.Aug 14 2024, 7:22 AM

tomek accepted this revision.Aug 19 2024, 6:20 AM

This revision is now accepted and ready to land.Aug 19 2024, 6:20 AM

rebase before landing

Harbormaster completed remote builds in B31190: Diff 43535.Aug 21 2024, 1:23 AM

Closed by commit rCOMM74b74fdfee46: [SQLite] deprecate `removeOutboundP2PMessagesOlderThan` and update to remove… (authored by kamil). · Explain WhyAug 21 2024, 2:57 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM74b74fdfee46: [SQLite] deprecate `removeOutboundP2PMessagesOlderThan` and update to remove….

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

use-peer-to-peer-message-handler.js

5 lines

types/

sqlite-types.js

2 lines

utils/

__mocks__/

config.js

2 lines

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

4 lines

SQLiteQueryExecutor.h

4 lines

SQLiteQueryExecutor.cpp

13 lines

NativeModules/

CommCoreModule.h

2 lines

CommCoreModule.cpp

6 lines

_generated/

commJSI-generated.cpp

commJSI.h

database/

sqlite-api.js

3 lines

schema/

CommCoreModuleSchema.js

2 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

4 lines

database/

sqlite-api.js

4 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

outbound-p2p-message-queries.test.js

19 lines

types/

sqlite-query-executor.js

5 lines

worker/

shared-worker.js

4 lines

types/

worker-types.js

8 lines

Diff 43535

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

View Options

lib/types/sqlite-types.js

View Options

lib/utils/mocks/config.js

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/database/sqlite-api.js

View Options

native/schema/CommCoreModuleSchema.js

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/database/sqlite-api.js

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

View Options

web/shared-worker/types/sqlite-query-executor.js

View Options

web/shared-worker/worker/shared-worker.js

View Options

[SQLite] deprecate `removeOutboundP2PMessagesOlderThan` and update to remove only one specific messageClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43535

lib/tunnelbroker/use-peer-to-peer-message-handler.js

lib/types/sqlite-types.js

lib/utils/__mocks__/config.js

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/database/sqlite-api.js

native/schema/CommCoreModuleSchema.js

web/cpp/SQLiteQueryExecutorBindings.cpp

web/database/sqlite-api.js

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/outbound-p2p-message-queries.test.js

web/shared-worker/types/sqlite-query-executor.js

web/shared-worker/worker/shared-worker.js

web/types/worker-types.js

[SQLite] deprecate `removeOutboundP2PMessagesOlderThan` and update to remove only one specific message
ClosedPublic
Actions

Revision Contents
Changeset List

lib/utils/mocks/config.js