Paths

Table of Contentst

Differential D13243

[lib] Add useNewThickThread
ClosedPublic
Actions

Authored by inka on Sep 5 2024, 1:16 AM.

Tags

None

Referenced Files

	F3007235: D13243.id44091.diff
	Fri, Oct 18, 7:14 PM

	Unknown Object (File)
	Thu, Oct 17, 11:19 PM

	Unknown Object (File)
	Thu, Oct 17, 8:39 PM

	Unknown Object (File)
	Thu, Oct 17, 6:32 AM

	Unknown Object (File)
	Tue, Oct 15, 12:05 PM

	Unknown Object (File)
	Tue, Oct 15, 8:17 AM

	Unknown Object (File)
	Mon, Oct 14, 2:28 PM

	Unknown Object (File)
	Sun, Oct 13, 7:15 PM

View All 36 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM7143343df124: [lib] Add useNewThickThread

Summary

issue: ENG-8442

Test Plan

Tested with the next diff, tested that it is possible to create a thick thread

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Sep 5 2024, 1:16 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 5 2024, 1:16 AM

inka added a child revision: D13244: [lib][web][native] Update createRealThreadFromPendingThread to handle thick thread creation.Sep 5 2024, 1:22 AM

Harbormaster completed remote builds in B31431: Diff 43889.Sep 5 2024, 1:33 AM

inka requested review of this revision.Sep 5 2024, 1:33 AM

tomek accepted this revision.Sep 5 2024, 2:56 AM

tomek added inline comments.

lib/hooks/thread-search-hooks.js
121–124 ↗	(On Diff #43889)	One thing to note is that these IDs should remain unchanged when we retry thread creation.
125 ↗	(On Diff #43889)

This revision is now accepted and ready to land.Sep 5 2024, 2:56 AM

inka added inline comments.Sep 6 2024, 6:46 AM

lib/hooks/thread-search-hooks.js
121–124 ↗	(On Diff #43889)	Will update this in the task handling retries ENG-9166, long with possibly other changes required for retires It is easier for me to implement this step by step.

Is there a better place to put this hook than thread-search-hooks?

ashoat added inline comments.Sep 9 2024, 5:31 AM

lib/types/thread-types.js
324–334 ↗	(On Diff #43889)	When spreading, you lose the read-only properties. These need to be wrapped in `$ReadOnly`, and it would be good to apply the same to the other types in this file

inka added a parent revision: D13306: [lib] Fix read only in thread-types.Sep 12 2024, 6:27 AM

Address review

lib/types/thread-types.js
324–334 ↗	(On Diff #43889)	Added D13306 to address other types

Harbormaster completed remote builds in B31562: Diff 44080.Sep 12 2024, 6:51 AM

Closed by commit rCOMM7143343df124: [lib] Add useNewThickThread (authored by inka). · Explain WhySep 12 2024, 8:04 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM7143343df124: [lib] Add useNewThickThread.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

thread-hooks.js

79 lines

types/

thread-types.js

12 lines

Diff 44080

lib/hooks/thread-hooks.js

Loading...

lib/types/thread-types.js

Loading...