Details
Tested by setting usingOlmViaTunnelbrokerForDMs to true. Not setting this flag yet, because it has other effects.
Tested that a thick thread gets created on both web and native.
Tested that if the flag is set to false, thin threads are created correctly
There is a problem with navigation - on both platfrms when the thick thread is created the user is not navigate to it. Instead they stay in the pending thread. I will address that in ENG-9147
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/input/input-state-container.react.js | ||
---|---|---|
470 ↗ | (On Diff #43890) | Should we mention that this is an operation that sends a text message? |
lib/shared/thread-actions-utils.js | ||
---|---|---|
105–108 ↗ | (On Diff #43890) | Should we add this invariant for thin sidebars too? |
native/input/input-state-container.react.js | ||
512–525 ↗ | (On Diff #43890) | What do you think of extracting these lines to a separate function? Lines 516-525 are already repeated on 585-594, and you're adding some more repeated code here |
web/input/input-state-container.react.js | ||
1323–1336 ↗ | (On Diff #43890) | Same question here |
web/input/input-state-container.react.js | ||
---|---|---|
1340–1343 ↗ | (On Diff #43890) | I guess this is causing this bug: ENG-9187. In the previous revision, it worked because my version was early exiting no matter if the thread was pending or not. This code is executed for thick threads also, so you create local entries with different IDs (messageInfo has localID, but for DMs, we're using a different uuid.v4, lines above). Later on, you early-exit before calling dispatchActionPromise so there is an entry in local which never gets removed. We should make sure that for thick threads we only use processAndSendDMOperation and not dispatch any other action (other actions are thin threads related). Worth checking other places that could possibly be affected. |
Address review, fix but from ENG-9187
web/input/input-state-container.react.js | ||
---|---|---|
1340–1343 ↗ | (On Diff #43890) | Thank you! |