Page MenuHomePhabricator
Differential D13267

[web][native] Show relationship prompt in thick PERSONAL threads
ClosedPublic
Actions

Authored by inka on Sep 9 2024, 3:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 12:01 PM
Unknown Object (File)
Tue, Apr 1, 5:14 AM
Unknown Object (File)
Tue, Apr 1, 4:51 AM
Unknown Object (File)
Mon, Mar 31, 9:44 AM
Unknown Object (File)
Sun, Mar 30, 8:41 PM
Unknown Object (File)
Tue, Mar 18, 9:01 PM
Unknown Object (File)
Wed, Mar 12, 1:00 AM
Unknown Object (File)
Fri, Mar 7, 1:46 AM
View All 65 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMf5bfcaa5f197: [web][native] Show relationship prompt in thick PERSONAL threads
Summary

issue: ENG-9188

Test Plan

Tested on web and native that buttons do show up in a chat with a user the current user is not friends with. Tested they don't show up in a chat with a user the usrrent user is friends with

Diff Detail

Repository
rCOMM Comm
Branch
inka/thread_ops
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
chat/
5 lines
web/
chat/
5 lines

Diff 43972

View Options

native/chat/message-list.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines async initUnauthorizedClient(): Promise<void> {
this.unauthorizedClient = this.unauthorizedClient =
new IdentityClient.IdentityClientServicePromiseClient( new IdentityClient.IdentityClientServicePromiseClient(
identitySocketAddr, identitySocketAddr,
null, null,
unauthorizedClientOpts, unauthorizedClientOpts,
); );
} }
async deleteUser( deleteUser: (
userID: string, userID: string,
deviceID: string, deviceID: string,
accessToken: string, accessToken: string,
): Promise<void> { ) => Promise<void> = async (
userID: string,
deviceID: string,
accessToken: string,
): Promise<void> => {
if (!this.authClient) { if (!this.authClient) {
const authLayer: IdentityServiceAuthLayer = { const authLayer: IdentityServiceAuthLayer = {
userID, userID,
deviceID, deviceID,
commServicesAccessToken: accessToken, commServicesAccessToken: accessToken,
}; };
await this.initAuthClient(authLayer); await this.initAuthClient(authLayer);
} }
if (this.authClient) { if (this.authClient) {
await this.authClient.deleteUser(new Empty()); await this.authClient.deleteUser(new Empty());
} else { } else {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
} };
} }
export { IdentityServiceClientWrapper }; export { IdentityServiceClientWrapper };
View Options

web/chat/chat-message-list.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines async initUnauthorizedClient(): Promise<void> {
this.unauthorizedClient = this.unauthorizedClient =
new IdentityClient.IdentityClientServicePromiseClient( new IdentityClient.IdentityClientServicePromiseClient(
identitySocketAddr, identitySocketAddr,
null, null,
unauthorizedClientOpts, unauthorizedClientOpts,
); );
} }
async deleteUser( deleteUser: (
userID: string, userID: string,
deviceID: string, deviceID: string,
accessToken: string, accessToken: string,
): Promise<void> { ) => Promise<void> = async (
userID: string,
deviceID: string,
accessToken: string,
): Promise<void> => {
if (!this.authClient) { if (!this.authClient) {
const authLayer: IdentityServiceAuthLayer = { const authLayer: IdentityServiceAuthLayer = {
userID, userID,
deviceID, deviceID,
commServicesAccessToken: accessToken, commServicesAccessToken: accessToken,
}; };
await this.initAuthClient(authLayer); await this.initAuthClient(authLayer);
} }
if (this.authClient) { if (this.authClient) {
await this.authClient.deleteUser(new Empty()); await this.authClient.deleteUser(new Empty());
} else { } else {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
} };
} }
export { IdentityServiceClientWrapper }; export { IdentityServiceClientWrapper };