Page MenuHomePhabricator
Differential D13344

[lib][native][web] send encrypted dms on web and native when editing entries on thick threads
ClosedPublic
Actions

Authored by will on Mon, Sep 16, 1:24 AM.
Tags
None
Referenced Files
F2762092: D13344.diff
Thu, Sep 19, 9:14 AM
Unknown Object (File)
Tue, Sep 17, 6:32 PM
Unknown Object (File)
Tue, Sep 17, 10:33 AM
Unknown Object (File)
Mon, Sep 16, 11:48 PM
Unknown Object (File)
Mon, Sep 16, 2:00 PM
Unknown Object (File)
Mon, Sep 16, 2:00 PM
Unknown Object (File)
Mon, Sep 16, 1:59 PM
Unknown Object (File)
Mon, Sep 16, 1:56 PM
Subscribers
None

Details

Reviewers
marcin
ashoat
tomek
kamil
Commits
rCOMM33107c27386d: [lib][native][web] send encrypted dms on web and native when editing entries on…
Summary

This uses e2ee dm ops with the save entry hook instead of the keyserver when sending entries in a thick thread

Depends on D13343

Test Plan

two accounts each with a web app and iOS simulator. Ensured on all four platforms/devices that editing entries showed between the four platforms when sending entries in a thick thread.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mon, Sep 16, 1:24 AM
will added a child revision: D13345: [lib][native][web] send encrypted dms on web and native when deleting on thick threads.Mon, Sep 16, 1:39 AM
Harbormaster completed remote builds in B31626: Diff 44198.Mon, Sep 16, 1:50 AM
will requested review of this revision.Mon, Sep 16, 1:50 AM
tomek accepted this revision.Mon, Sep 16, 5:34 AM
tomek added a reviewer: kamil.
kamil accepted this revision.Mon, Sep 16, 8:19 AM
kamil added inline comments.
lib/actions/entry-actions.js
364 ↗(On Diff #44198)
This revision is now accepted and ready to land.Mon, Sep 16, 8:19 AM
will updated this revision to Diff 44238.Mon, Sep 16, 1:35 PM

review feedback

Harbormaster failed remote builds in B31650: Diff 44238!Mon, Sep 16, 1:52 PM
Harbormaster completed remote builds in B31650: Diff 44238.Mon, Sep 16, 1:58 PM
will updated this revision to Diff 44241.Mon, Sep 16, 2:00 PM

rebase

Harbormaster completed remote builds in B31653: Diff 44241.Mon, Sep 16, 2:21 PM
Closed by commit rCOMM33107c27386d: [lib][native][web] send encrypted dms on web and native when editing entries on… (authored by will). · Explain WhyMon, Sep 16, 2:27 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM33107c27386d: [lib][native][web] send encrypted dms on web and native when editing entries on….

Revision Contents
Changeset List

PathSize
lib/
actions/
86 lines
native/
calendar/
21 lines
web/
calendar/
21 lines

Diff 44250

View Options

lib/actions/entry-actions.js

Loading...
View Options

native/calendar/entry.react.js

Loading...
View Options

web/calendar/entry.react.js

Loading...