Page MenuHomePhabricator
Differential D13410

[lib] Make blob holder generator a higher order function
AcceptedPublic
Actions

Authored by bartek on Fri, Sep 20, 6:25 AM.
Tags
None
Referenced Files
F2784793: D13410.diff
Fri, Sep 20, 6:52 PM
F2779446: D13410.id44379.diff
Fri, Sep 20, 11:10 AM
F2779280: D13410.id44382.diff
Fri, Sep 20, 10:08 AM
F2779278: D13410.id44379.diff
Fri, Sep 20, 10:08 AM
F2779258: D13410.id.diff
Fri, Sep 20, 10:07 AM
F2779230: D13410.diff
Fri, Sep 20, 10:06 AM
F2779223: D13410.id44382.diff
Fri, Sep 20, 10:05 AM
F2779079: D13410.id.diff
Fri, Sep 20, 9:06 AM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Summary

This will be handy in te next diff to avoid calling getSigningPublicKey() for each holder

Test Plan

Repeated plan from D13401

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Fri, Sep 20, 6:25 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 20, 6:25 AM
bartek added a child revision: D13411: [lib] Process blob holders in DM ops.Fri, Sep 20, 6:30 AM
Harbormaster failed remote builds in B31739: Diff 44373!Fri, Sep 20, 6:43 AM
bartek updated this revision to Diff 44379.Fri, Sep 20, 6:47 AM

Add type annotation

bartek published this revision for review.Fri, Sep 20, 6:51 AM
bartek added inline comments.
lib/utils/blob-service.js
70–71 ↗(On Diff #44379)

Flow complained otherwise

bartek updated this revision to Diff 44382.Fri, Sep 20, 6:56 AM

Flow

Harbormaster failed remote builds in B31743: Diff 44379!Fri, Sep 20, 7:04 AM
Harbormaster completed remote builds in B31746: Diff 44382.Fri, Sep 20, 7:16 AM
kamil accepted this revision.Fri, Sep 20, 8:25 AM

Accepting but wondering, looking at the next diff, can't we just pass deviceID as a param to generateBlobHolder (it could be retrieved from getAuthMetadata)? Seems cleaner to me but not feeling strongly.

Separately, this reminds me of ENG-8192.

This revision is now accepted and ready to land.Fri, Sep 20, 8:25 AM

Revision Contents
Changeset List

PathSize
lib/
utils/
12 lines

Diff 44382

View Options

lib/utils/blob-service.js

Loading...