[lib] Update useUserProfileThreadInfo to consider thick threads
ClosedPublic
Actions

Authored by ashoat on Mon, Sep 30, 9:42 PM.

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM2d4e0c353da3: [lib] Update useUserProfileThreadInfo to consider thick threads

Summary

If a thick thread exists with the user whose profile we are viewing, we should display it.

When there are multiple, we'll select the oldest thread (by creation time). This matches behavior of pendingToRealizedThreadIDsSelector and useExistingThreadInfoFinder.

Depends on D13532

Test Plan

Tested viewing user profile on both web and native with a user with whom the viewer has a thick thread

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, Sep 30, 9:42 PM

ashoat added a child revision: D13534: [lib] Simplify useExistingThreadInfoFinder.

Harbormaster completed remote builds in B31949: Diff 44714.Mon, Sep 30, 9:59 PM

ashoat requested review of this revision.Mon, Sep 30, 9:59 PM

Why do we expect to have multiple private chats, or multiple personal chats with one user? It's it impossible?

In D13533#380315, @inka wrote:

Why do we expect to have multiple private chats, or multiple personal chats with one user? It's it impossible?

It is possible to create multiple PERSONAL threads simultaneously: when a thread is created on a device that is offline, then we create a thread on another device, and then they start sending operations - there will be two PERSONAL threads on both devices.

tomek accepted this revision.Tue, Oct 1, 8:35 AM

This revision is now accepted and ready to land.Tue, Oct 1, 8:35 AM

Closed by commit rCOMM2d4e0c353da3: [lib] Update useUserProfileThreadInfo to consider thick threads (authored by ashoat). · Explain WhyTue, Oct 1, 9:06 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2d4e0c353da3: [lib] Update useUserProfileThreadInfo to consider thick threads.