Paths

Table of Contentst

Differential D13550

[web] Hide members option in ThreadMenu for all private and personal threads
ClosedPublic
Actions

Authored by ashoat on Mon, Sep 30, 10:10 PM.

Tags

None

Referenced Files

	F2860755: D13550.diff
	Tue, Oct 1, 7:39 PM

Subscribers

None

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM068cfc52f2d2: [web] Hide members option in ThreadMenu for all private and personal threads

Summary

We currently only hide this menu option for threadTypes.GENESIS_PERSONAL. I think we should match behavior for threadTypes.PERSONAL, and I also figure we can hide the menu option for private threads too (threadTypes.PRIVATE and threadTypes.GENESIS_PRIVATE, which are for a user chatting with themselves).

Depends on D13549

Test Plan

Confirm that members options doesn't appear in ThreadMenu on web when viewing a PRIVATE thread

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mon, Sep 30, 10:10 PM

ashoat added a child revision: D13551: [lib][native][web] Use threadTypeIsPersonal where possible.

Harbormaster completed remote builds in B31966: Diff 44731.Mon, Sep 30, 11:22 PM

ashoat requested review of this revision.Mon, Sep 30, 11:22 PM

tomek accepted this revision.Tue, Oct 1, 8:18 AM

This revision is now accepted and ready to land.Tue, Oct 1, 8:18 AM

Closed by commit rCOMM068cfc52f2d2: [web] Hide members option in ThreadMenu for all private and personal threads (authored by ashoat). · Explain WhyTue, Oct 1, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM068cfc52f2d2: [web] Hide members option in ThreadMenu for all private and personal threads.

Revision Contents
Changeset List

Path

Size

web/

chat/

thread-menu.react.js

8 lines

Diff 44731

web/chat/thread-menu.react.js

Loading...