[keyserver] implement invite link button to frog hono route
AcceptedPublic
Actions

Authored by will on Tue, Nov 19, 9:51 PM.

Details

Reviewers

varun
ashoat

Summary

This implements the invite link button in the frame. We take a invite link parameter in the route. The button will redirect to this link

We also check if the invite link parameter is a valid Comm invite link by checking if it is prefixed by https://comm.app/invite/. If not, we default to https://comm.app

Depends on D13947

Test Plan

Used the warpcast frame validator https://warpcast.com/~/developers to display the frame and confirmed button redirected to invite link provided as the parameter with the following url in the warpcast frame validator: https://<keyserver url>/https%3A%2F%2Fcomm.app%2Finvite%2Fcryptoleft

Used a different link than a Comm link as a parameter and confirmed it still defaults to https://comm.app

Diff Detail

Repository

rCOMM Comm

Branch

wyilio/frames

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Tue, Nov 19, 9:51 PM

Herald added a subscriber: tomek. · View Herald TranscriptTue, Nov 19, 9:51 PM

will added inline comments.Tue, Nov 19, 9:59 PM

keyserver/flow-typed/npm/frog_v0.18.x.js
12–18	We won't actually be using a regular `Button` here. For our frame work, we'll end up using only variants like `Button.Link`
keyserver/src/frog/frog.js
18	Had the invite link button default to the Comm homepage. We could also fail to respond with a frame or use a different default link like the Comm download page

will edited the test plan for this revision. (Show Details)Tue, Nov 19, 10:01 PM

Harbormaster completed remote builds in B32721: Diff 45893.Tue, Nov 19, 10:08 PM

will requested review of this revision.Tue, Nov 19, 10:08 PM

ashoat accepted this revision.Wed, Nov 20, 4:20 AM

ashoat added inline comments.

keyserver/flow-typed/npm/frog_v0.18.x.js
15–16	Are you sure these are the only two props on this component? If not, use `...`
18	You should be using `...` to indicate there are other properties that you haven't typed. Please make sure you grok the types you're using here... you shouldn't be putting up diffs like D13947 if there are lines (like `...`) that you don't understand