Page MenuHomePhabricator

[native] Move text update and editing logic in ChatInputBar to function component
ClosedPublic

Authored by angelika on Fri, Nov 22, 4:38 AM.
Tags
None
Referenced Files
F3388897: D14012.id46116.diff
Fri, Nov 29, 4:32 PM
F3387862: D14012.id45952.diff
Fri, Nov 29, 11:33 AM
Unknown Object (File)
Thu, Nov 28, 7:33 PM
Unknown Object (File)
Thu, Nov 28, 1:12 PM
Unknown Object (File)
Thu, Nov 28, 12:24 PM
Unknown Object (File)
Wed, Nov 27, 1:34 PM
Unknown Object (File)
Wed, Nov 27, 8:09 AM
Unknown Object (File)
Tue, Nov 26, 8:50 PM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Sun, Nov 24, 6:15 PM