Details
Details
Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:
- focus the text input and verify the keyboard is up and the camera buttons are animated correctly
- try to send the message, verify the send button is animated correctly
- verify the text input can be unfocused and keyboard is hidden
- verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
- verify the edit mode works by editing a message
- try to close the chat while editing a message - the alert should be shown
- try to join a thread
- try to select typed text
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/chat/chat-input-bar.react.js | ||
|---|---|---|
| 1210 ↗ | (On Diff #45958) | There's an error here... in the old version the !isEditMode check was checking the result of invoking the isEditMode function, but here you're just checking the function itself, which is always defined (so this check will always be false) |
| 1260 ↗ | (On Diff #45958) | Same here |