Paths

Table of Contentst

[native][web] Handle use_new_flow for Identity V1 login calls
ClosedPublic
Actions

Authored by bartek on Nov 25 2024, 11:39 AM.

Details

Reviewers

varun
kamil

Commits

rCOMM430be00c2a11: [native][web] Handle use_new_flow for Identity V1 login calls

Summary

Address ENG-9717

For V1 login we can reuse existing logic for unsupported_version to also work for use_new_flow. Desired behavior is the same.
Updated all Identity callsites.

Depends on D13954

Test Plan

Mocked local Identity to return use_new_flow for all login RPCs. Confirmed that login attempt on device fails and a message is displayed

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 25 2024, 11:39 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 25 2024, 11:39 AM

bartek added a child revision: D14033: [lib] Extract hook to send logout message to primary device.Nov 25 2024, 11:42 AM

Harbormaster completed remote builds in B32806: Diff 45993.Nov 25 2024, 12:06 PM

bartek published this revision for review.Nov 25 2024, 12:26 PM

kamil accepted this revision.Nov 26 2024, 9:46 AM

This revision is now accepted and ready to land.Nov 26 2024, 9:46 AM

Closed by commit rCOMM430be00c2a11: [native][web] Handle use_new_flow for Identity V1 login calls. · Explain WhyNov 29 2024, 1:03 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM430be00c2a11: [native][web] Handle use_new_flow for Identity V1 login calls.

Revision Contents
Changeset List

Path

Size

native/

account/

fullscreen-siwe-panel.react.js

3 lines

log-in-panel.react.js

3 lines

registration/

existing-ethereum-account.react.js

3 lines

web/

account/

siwe-login-form.react.js

3 lines

traditional-login-form.react.js

3 lines

Diff 45993

View Options

native/account/fullscreen-siwe-panel.react.js

View Options

native/account/log-in-panel.react.js

View Options

native/account/registration/existing-ethereum-account.react.js

View Options

web/account/siwe-login-form.react.js

View Options

web/account/traditional-login-form.react.js

[native][web] Handle use_new_flow for Identity V1 login callsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45993

native/account/fullscreen-siwe-panel.react.js

native/account/log-in-panel.react.js

native/account/registration/existing-ethereum-account.react.js

web/account/siwe-login-form.react.js

web/account/traditional-login-form.react.js

[native][web] Handle use_new_flow for Identity V1 login calls
ClosedPublic
Actions

Revision Contents
Changeset List