Page MenuHomePhabricator
Differential D14090

[native] Navigate to a SIWE backup screen
ClosedPublic
Actions

Authored by tomek on Dec 6 2024, 9:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 6, 9:28 PM
Unknown Object (File)
Mon, Jan 6, 10:29 AM
Unknown Object (File)
Sun, Jan 5, 1:55 PM
Unknown Object (File)
Sun, Jan 5, 10:47 AM
Unknown Object (File)
Sun, Jan 5, 9:07 AM
Unknown Object (File)
Fri, Jan 3, 2:44 PM
Unknown Object (File)
Fri, Jan 3, 1:49 PM
Unknown Object (File)
Fri, Jan 3, 12:01 PM
View All 53 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
Commits
rCOMM609f9084992c: [native] Navigate to a SIWE backup screen
Summary

After successful login a user should be redirected to sign a backup

https://linear.app/comm/issue/ENG-8203/implement-navigation-flow-for-new-siwe-log-in

Depends on D14164

Test Plan

Connect the wallet using restore flow. The user should get navigated to the new screen.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Dec 6 2024, 9:37 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2024, 9:37 AM
Harbormaster completed remote builds in B32952: Diff 46246.Dec 6 2024, 9:55 AM
tomek requested review of this revision.Dec 6 2024, 9:55 AM
tomek updated this revision to Diff 46289.Tue, Dec 10, 6:55 AM

Rebase

Harbormaster completed remote builds in B32983: Diff 46289.Tue, Dec 10, 7:22 AM
tomek edited the summary of this revision. (Show Details)Tue, Dec 17, 7:30 AM
tomek edited the test plan for this revision. (Show Details)
tomek added a parent revision: D14164: [native] Update the SIWE backup restore screen.
tomek removed a parent revision: D14085: [native] Render SIWE restore panel.
tomek updated this revision to Diff 46557.Tue, Dec 17, 7:32 AM

Rebase and update the approach

tomek edited the summary of this revision. (Show Details)Tue, Dec 17, 7:33 AM
tomek added a child revision: D14165: [native] Perform the backup restoration.Tue, Dec 17, 7:36 AM
Harbormaster completed remote builds in B33166: Diff 46557.Tue, Dec 17, 7:58 AM
tomek updated this revision to Diff 46577.Thu, Dec 19, 3:28 AM

Remove a button from the backup menu

kamil accepted this revision.Thu, Dec 19, 3:28 AM
kamil added inline comments.
native/account/restore-prompt-screen.react.js
82 ↗(On Diff #46557)

nit: we can remove useCallback now

104 ↗(On Diff #46557)

This is something we need to update as part of removing social proof refresh during restore but for now looks good

native/profile/backup-menu.react.js
229 ↗(On Diff #46557)

This will be removed I think

This revision is now accepted and ready to land.Thu, Dec 19, 3:28 AM
tomek mentioned this in D14164: [native] Update the SIWE backup restore screen.Thu, Dec 19, 3:30 AM
tomek updated this revision to Diff 46578.Thu, Dec 19, 3:32 AM

Shorthand

Harbormaster completed remote builds in B33181: Diff 46577.Thu, Dec 19, 3:46 AM
Harbormaster completed remote builds in B33182: Diff 46578.Thu, Dec 19, 3:48 AM
Closed by commit rCOMM609f9084992c: [native] Navigate to a SIWE backup screen (authored by tomek). · Explain WhyThu, Dec 19, 6:32 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM609f9084992c: [native] Navigate to a SIWE backup screen.

Revision Contents
Changeset List

Diff 46586

View Options

native/account/restore-backup-screen.react.js

Loading...
View Options

native/account/restore-password-account-screen.react.js

Loading...
View Options

native/account/restore-prompt-screen.react.js

Loading...
View Options

native/backup/restore-siwe-backup.react.js

Loading...
View Options

native/profile/backup-menu.react.js

Loading...