Page MenuHomePhabricator
Differential D14391

[native] ColdStartTracker
ClosedPublic
Actions

Authored by varun on Feb 19 2025, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 8:49 AM
Unknown Object (File)
Thu, Mar 27, 2:55 PM
Unknown Object (File)
Wed, Mar 26, 2:02 AM
Unknown Object (File)
Tue, Mar 25, 1:44 PM
Unknown Object (File)
Tue, Mar 25, 12:47 AM
Unknown Object (File)
Mon, Mar 24, 3:31 AM
Unknown Object (File)
Sat, Mar 22, 7:07 AM
Unknown Object (File)
Wed, Mar 19, 9:59 PM
View All 32 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMMebee92ea5903: [native] ColdStartTracker
Summary

I'll use this component in DisplayCommunityDirectoryPrompt to get the coldStartCount. We'll use this count to determine when to display the prompt

Test Plan

Added logs and confirmed that the count resets on logout and increments on cold start, but not when the app is just backgrounded.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Feb 19 2025, 7:47 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 19 2025, 7:47 PM
Harbormaster completed remote builds in B33554: Diff 47166.Feb 19 2025, 8:08 PM
varun requested review of this revision.Feb 19 2025, 8:08 PM
ashoat accepted this revision.Feb 19 2025, 8:22 PM
ashoat added inline comments.
lib/reducers/alert-reducer.js
23–25

Let's do else if to match the other reducers

30

We need to reset the state on logout. Can you add a condition for logOutActionTypes.started before landing?

This revision is now accepted and ready to land.Feb 19 2025, 8:22 PM
ashoat mentioned this in D14053: [native] DisplayCommunityDirectoryPrompt.Feb 27 2025, 11:37 PM
varun added inline comments.Mar 1 2025, 9:04 AM
lib/reducers/alert-reducer.js
30

resetUserSpecificState should clear the alertStore on logout, so we don't need a condition for logOutActionTypes.started

Closed by commit rCOMMebee92ea5903: [native] ColdStartTracker (authored by varun). · Explain WhyMar 1 2025, 9:08 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMebee92ea5903: [native] ColdStartTracker.
varun added a child revision: D14053: [native] DisplayCommunityDirectoryPrompt.Mar 1 2025, 9:09 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
3 lines
reducers/
12 lines
types/
1 line
4 lines
utils/
1 line
native/
components/
33 lines
redux/
1 line
2 lines
web/
redux/
1 line

Diff 47166

View Options

lib/actions/alert-actions.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

lib/reducers/alert-reducer.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

lib/types/alert-types.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

lib/types/redux-types.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

lib/utils/reducers-utils.test.js

Loading...
View Options

native/components/cold-start-tracker.react.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

native/root.react.js

Loading...
View Options

web/redux/default-state.js

Loading...