Page MenuHomePhabricator
Differential D14420

[native] navigate to CommunityJoinerModal if user accepts prompt
ClosedPublic
Actions

Authored by varun on Feb 27 2025, 10:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 10:32 PM
Unknown Object (File)
Tue, Apr 1, 12:10 PM
Unknown Object (File)
Tue, Apr 1, 1:59 AM
Unknown Object (File)
Mon, Mar 31, 9:39 PM
Unknown Object (File)
Mon, Mar 31, 9:33 PM
Unknown Object (File)
Mon, Mar 31, 3:12 AM
Unknown Object (File)
Sat, Mar 29, 11:54 AM
Unknown Object (File)
Fri, Mar 28, 11:35 PM
View All 23 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM83a42c0da9f8: [native] navigate to CommunityJoinerModal if user accepts prompt
Summary

Depends on D14378

We were already passing the communities to the bottom sheet component but the
types had not been updated. This diff updates the types and handles navigating to
directory modal when the user accepts the prompt

Test Plan

Confirmed that accepting the prompt closes the bottom sheet and takes me to the modal

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Feb 27 2025, 10:19 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 27 2025, 10:19 PM
varun added a child revision: D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet.Feb 27 2025, 10:42 PM
varun published this revision for review.Feb 28 2025, 2:48 PM

CI has been stuck for a day

ashoat accepted this revision.Feb 28 2025, 3:28 PM
This revision is now accepted and ready to land.Feb 28 2025, 3:28 PM
ashoat mentioned this in D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet.Feb 28 2025, 3:32 PM
varun added inline comments.Mar 1 2025, 9:00 AM
native/components/directory-prompt-bottom-sheet.react.js
69 ↗(On Diff #47297)

this goBack is unnecessary. the NUX tip replaces the CommunityJoinerModal

This revision was landed with ongoing or failed builds.Mar 1 2025, 2:25 PM
Closed by commit rCOMM83a42c0da9f8: [native] navigate to CommunityJoinerModal if user accepts prompt (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM83a42c0da9f8: [native] navigate to CommunityJoinerModal if user accepts prompt.

Revision Contents
Changeset List

PathSize
native/
components/
26 lines
navigation/
3 lines

Diff 47324

View Options

native/components/directory-prompt-bottom-sheet.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...