Create a table where the operations are stored and allow quick query by the operation type.
https://linear.app/comm/issue/ENG-10333/create-sqlite-table-and-queries
Paths
| Differential D14447 Authored by tomek on Mon, Mar 17, 6:47 AM.
Tags None Referenced Files
Subscribers
Details Summary Create a table where the operations are stored and allow quick query by the operation type. https://linear.app/comm/issue/ENG-10333/create-sqlite-table-and-queries Test Plan Tested the whole stack on both native and web:
unshimDMOperations( state, dmOperationTypes.CREATE_THREAD, handleReduxMigrationFailure, ): MigrationFunction<WebNavInfo, AppState>),
Additionally, tested the migration on native by removing the table from the code that creates the DB, bumping the version to make sure that the migration is run, and adding some code in JS that queries the table.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptMon, Mar 17, 6:47 AM2025-03-17 06:47:03 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Mar 17, 6:58 AM2025-03-17 06:58:47 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Mar 17, 7:57 AM2025-03-17 07:57:56 (UTC-7) Harbormaster completed remote builds in B33735: Diff 47425.Tue, Mar 18, 3:42 AM2025-03-18 03:42:12 (UTC-7) kamil added inline comments. This revision is now accepted and ready to land.Tue, Mar 18, 7:31 AM2025-03-18 07:31:31 (UTC-7) Harbormaster failed remote builds in B33761: Diff 47453!Wed, Mar 19, 5:36 AM2025-03-19 05:36:46 (UTC-7) Harbormaster completed remote builds in B33761: Diff 47453.Wed, Mar 19, 5:58 AM2025-03-19 05:58:44 (UTC-7) Closed by commit rCOMM1ec1670833cf: [native] Create table and queries for DMOperations (authored by tomek). · Explain WhyWed, Mar 19, 9:56 AM2025-03-19 09:56:55 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 47425 native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
native/cpp/CommonCpp/DatabaseManagers/entities/DMOperation.h
native/ios/Comm.xcodeproj/project.pbxproj
web/shared-worker/_generated/comm_query_executor.wasm
|