Page MenuHomePhabricator
Differential D14498

[identity] Split OTK deletion into smaller functions
ClosedPublic
Actions

Authored by bartek on Tue, Mar 25, 6:48 AM.
Tags
None
Referenced Files
F6201199: D14498.diff
Wed, Apr 23, 8:02 PM
F6201109: D14498.diff
Wed, Apr 23, 8:00 PM
Unknown Object (File)
Thu, Apr 10, 2:26 AM
Unknown Object (File)
Sun, Apr 6, 3:35 PM
Unknown Object (File)
Fri, Apr 4, 9:50 AM
Unknown Object (File)
Fri, Apr 4, 6:22 AM
Unknown Object (File)
Fri, Apr 4, 5:10 AM
Unknown Object (File)
Mon, Mar 31, 7:58 PM
View All 22 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMMcdc293df59ec: [identity] Split OTK deletion into smaller functions
Summary

Part of ENG-10413.
Split OTK removal into smaller functions and gave comments about their purpose, to avoid mistakes in the future

Depends on D14497

Test Plan

Tested on staging along with the rest of the stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Tue, Mar 25, 6:48 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Mar 25, 6:48 AM
bartek added a child revision: D14499: [identity] Fix OTK removal in clean_up_devices_data.Tue, Mar 25, 6:50 AM
Harbormaster completed remote builds in B33822: Diff 47537.Tue, Mar 25, 7:11 AM
bartek published this revision for review.Tue, Mar 25, 7:43 AM
kamil accepted this revision.Tue, Mar 25, 11:44 AM
kamil added inline comments.
services/identity/src/database/one_time_keys.rs
400 ↗(On Diff #47537)

typo

This revision is now accepted and ready to land.Tue, Mar 25, 11:44 AM
Closed by commit rCOMMcdc293df59ec: [identity] Split OTK deletion into smaller functions (authored by bartek). · Explain WhyWed, Mar 26, 7:55 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMcdc293df59ec: [identity] Split OTK deletion into smaller functions.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
41 lines

Diff 47565

View Options

services/identity/src/database/one_time_keys.rs

Loading...