https://linear.app/comm/issue/ENG-804/fix-services-images
Moved as much as possible to the parent base image, bumped images' versions.
Depends on D3198
Paths
| Differential D3268 Authored by • karol on Feb 23 2022, 8:47 AM.
Tags None Referenced Files
Subscribers
Details Summary https://linear.app/comm/issue/ENG-804/fix-services-images Moved as much as possible to the parent base image, bumped images' versions. Depends on D3198 Test Plan cd services yarn build-backup-base yarn build-tunnelbroker-base yarn build-blob-base yarn build-backup-base yarn test-blob-service yarn test-backup-service yarn run-tunnelbroker-service
Diff Detail
Event TimelineHerald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 23 2022, 8:47 AM2022-02-23 08:47:09 (UTC-8) Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2022, 9:20 AM2022-02-23 09:20:50 (UTC-8) • karol edited the summary of this revision. (Show Details)Feb 24 2022, 2:44 AM2022-02-24 02:44:11 (UTC-8) • karol added a child revision: D3200: [services] Backup - dev mode.Feb 24 2022, 2:56 AM2022-02-24 02:56:53 (UTC-8) Harbormaster completed remote builds in B7011: Diff 9889.Feb 24 2022, 2:59 AM2022-02-24 02:59:55 (UTC-8) This revision is now accepted and ready to land.Feb 25 2022, 3:59 AM2022-02-25 03:59:06 (UTC-8) Herald added a reviewer: ashoat. · View Herald TranscriptFeb 25 2022, 3:59 AM2022-02-25 03:59:06 (UTC-8) This revision now requires review to proceed.Feb 25 2022, 3:59 AM2022-02-25 03:59:06 (UTC-8) Comment Actions Can you be more precise about what is being "fixed"? I thought that we had some strange situation where either blob depending on backup, or backup depended on blob... but looking at the "before" state here, I can't seem to find where that dependency is... This revision is now accepted and ready to land.Feb 25 2022, 12:45 PM2022-02-25 12:45:55 (UTC-8) • karol retitled this revision from [services] fix images to [services] Move as much content as possible to the parent base image.Mar 2 2022, 4:50 AM2022-03-02 04:50:36 (UTC-8) Comment Actions
This is done in D3198, here we
I edited the revision's title. Harbormaster completed remote builds in B7102: Diff 10012.Mar 2 2022, 5:43 AM2022-03-02 05:43:49 (UTC-8) Comment Actions Good idea. There are a couple other improvements possible now, in particular building gRPC with the -DgRPC_SSL_PROVIDER=package and -DgRPC_ZLIB_PROVIDER=package flags to avoid building BoringSSL and rebuilding zlib and instead use the system libs installed in the base image.
Comment Actions
Huh? It's confusing to read this. In D3198 you clearly indicate that the confusing dependency is not addressed – in fact, in that diff you created a Linear task to track that issue (on my request). But now you seem to be indicating that that diff solves the confusing dependency? Honestly, I think the reason for my continued confusion is that you responded to my request to be "more precise" with a total of 12 words. Can you please try again, and this time explain in detail an answer to my question? Here's the question again:
Where is the dependency? Does it still exist? Comment Actions Requesting changes for @jimpo's comment. @karol-bisztyga, I'm pretty sure that the issues around build caching in Docker and the reasoning for merging these RUN commands has been discussed before in diffs that you have been on. See my comment here – it's concerning to me that you missed that whole discussion, and then made this change without doing the appropriate research This revision now requires changes to proceed.Mar 2 2022, 10:46 PM2022-03-02 22:46:48 (UTC-8) Comment Actions Here I said:
And by "it" I meant this confusing dependency, this was said in D3198. So, once again:
I see now that the description in this task was probably misleading so I updated it. I hope it's now all clear, I'm not sure what else I can say to put yet more light on this, it looks pretty straightforward to me.
Yes, this is an oversight on my end, sorry, I'm going to fix this. @jimpo thanks for clarifying and catching this! Comment Actions
Is there a task for this? Harbormaster completed remote builds in B7128: Diff 10039.Mar 3 2022, 3:49 AM2022-03-03 03:49:08 (UTC-8) Comment Actions
Just made one https://linear.app/comm/issue/ENG-824/dont-build-redundant-dependencies-for-grpc Comment Actions
Thanks for this explanation – I understand now!!
This revision is now accepted and ready to land.Mar 3 2022, 10:16 PM2022-03-03 22:16:32 (UTC-8) Comment Actions
thanks Harbormaster completed remote builds in B7140: Diff 10051.Mar 4 2022, 4:10 AM2022-03-04 04:10:39 (UTC-8) Harbormaster completed remote builds in B7142: Diff 10053.Mar 4 2022, 4:35 AM2022-03-04 04:35:42 (UTC-8) Harbormaster failed remote builds in B7321: Diff 10322!Mar 14 2022, 6:38 AM2022-03-14 06:38:12 (UTC-7) Harbormaster completed remote builds in B7330: Diff 10331.Mar 14 2022, 8:37 AM2022-03-14 08:37:56 (UTC-7)
Harbormaster completed remote builds in B7367: Diff 10371.Mar 15 2022, 2:56 AM2022-03-15 02:56:45 (UTC-7) Closed by commit rCOMM15911abd9dee: [services] Move as much content as possible to the parent base image (authored by • karol). · Explain WhyMar 15 2022, 3:20 AM2022-03-15 03:20:13 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 10331 services/backup/docker-base/Dockerfile
services/backup/docker-base/contents/install_aws_sdk.sh
services/backup/docker-base/contents/install_folly.sh
services/backup/docker-server/Dockerfile
|