Page MenuHomePhabricator
Differential D3744

[web] Add callback adding members to thread in `AddMembersModal`
ClosedPublic
Actions

Authored by • jacek on Apr 15 2022, 4:42 AM.
Tags
None
Referenced Files
F4093350: D3744.diff
Sun, Feb 16, 6:53 PM
Unknown Object (File)
Sun, Feb 9, 6:42 PM
Unknown Object (File)
Wed, Feb 5, 8:51 PM
Unknown Object (File)
Tue, Feb 4, 6:30 AM
Unknown Object (File)
Fri, Jan 31, 11:44 PM
Unknown Object (File)
Sun, Jan 26, 4:49 AM
Unknown Object (File)
Jan 15 2025, 9:16 PM
Unknown Object (File)
Jan 6 2025, 9:31 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
tomek
atul
• benschac
Commits
rCOMM5261b164eb1e: [web] Add callback adding members to thread in `AddMembersModal`
Summary

Introduce callback for dispatching server action in AddMembersModal. It is executed after selecting all users to add and pressing "Add selected members" button.

Test Plan

After pressing the button, all selected users should be added to the thread

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Apr 15 2022, 4:42 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 15 2022, 4:42 AM
• jacek added a parent revision: D3743: [web] Introduce searching users in `AddMembersModal`.Apr 15 2022, 4:56 AM
• jacek added reviewers: tomek, atul, • benschac.
Harbormaster completed remote builds in B8230: Diff 11514.Apr 15 2022, 8:27 AM
• jacek requested review of this revision.Apr 15 2022, 8:27 AM
tomek accepted this revision.Apr 15 2022, 9:38 AM
This revision is now accepted and ready to land.Apr 15 2022, 9:38 AM
• jacek updated this revision to Diff 11782.Apr 22 2022, 3:41 AM

rebase, convert set to array

Harbormaster completed remote builds in B8443: Diff 11782.Apr 22 2022, 3:57 AM
• jacek updated this revision to Diff 11975.Apr 27 2022, 2:39 AM

rebase

Harbormaster completed remote builds in B8591: Diff 11975.Apr 27 2022, 2:51 AM
• jacek updated this revision to Diff 12103.Apr 29 2022, 3:18 AM

rebase

Harbormaster completed remote builds in B8692: Diff 12103.Apr 29 2022, 3:34 AM
Closed by commit rCOMM5261b164eb1e: [web] Add callback adding members to thread in `AddMembersModal` (authored by • jacek). · Explain WhyApr 29 2022, 3:44 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM5261b164eb1e: [web] Add callback adding members to thread in `AddMembersModal`.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
members/
30 lines

Diff 11975

View Options

web/modals/threads/members/add-members-modal.react.js

Loading...