Paths

Table of Contentst

[services] Tests - Update packages
ClosedPublic
Actions

Authored by • karol on Jun 13 2022, 1:51 PM.

Details

Reviewers

tomek
varun
ashoat

Commits

rCOMM3871d95d9e36: [services] Tests - Update packages

Summary

Depends on D4248

I updated the list of packages necessary for the tests to run.

Test Plan

cd services/commtest && COMM_TEST_TARGET=backup cargo build

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jun 13 2022, 1:51 PM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 13 2022, 1:51 PM

• karol edited the summary of this revision. (Show Details)Jun 13 2022, 2:21 PM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun.

• karol added a parent revision: D4248: [services] Tests - Add chunk limit to tools.

• karol added a child revision: D4250: [services] Tests - Add dummy tests.

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 13 2022, 5:04 PM

Harbormaster failed remote builds in B9725: Diff 13470!

CI failed on an unrelated stage - key server
CI services build - no space left on device

Harbormaster completed remote builds in B9725: Diff 13470.Jun 14 2022, 10:28 AM

Please always put me as a reviewer on diffs that touch external dependencies. Full list of situations to add me here

We're making sure none of these are copyleft-licensed, right? (eg GPL)

In D4249#120152, @ashoat wrote:

We're making sure none of these are copyleft-licensed, right? (eg GPL)

They're all MIT/Apache

varun accepted this revision.Jun 14 2022, 4:57 PM

This revision is now accepted and ready to land.Jun 14 2022, 4:57 PM

retrigger CI

Harbormaster completed remote builds in B10145: Diff 14015.Jun 30 2022, 2:41 PM

Closed by commit rCOMM3871d95d9e36: [services] Tests - Update packages. · Explain WhyJul 8 2022, 9:30 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM3871d95d9e36: [services] Tests - Update packages.

Revision Contents
Changeset List

Path

Size

services/

commtest/

Cargo.lock

Cargo.toml

6 lines

Diff 14015

View Options

services/commtest/Cargo.lock