Page MenuHomePhabricator
Differential D4249

[services] Tests - Update packages
ClosedPublic
Actions

Authored by • karol on Jun 13 2022, 6:51 AM.
Tags
None
Referenced Files
F2907184: D4249.diff
Sun, Oct 6, 10:43 AM
Unknown Object (File)
Fri, Sep 27, 3:45 AM
Unknown Object (File)
Wed, Sep 18, 10:34 PM
Unknown Object (File)
Thu, Sep 12, 7:05 AM
Unknown Object (File)
Sep 5 2024, 1:31 PM
Unknown Object (File)
Sep 5 2024, 1:31 PM
Unknown Object (File)
Sep 5 2024, 1:31 PM
Unknown Object (File)
Sep 5 2024, 1:31 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
ashoat
Commits
rCOMM3871d95d9e36: [services] Tests - Update packages
Summary

Depends on D4248

I updated the list of packages necessary for the tests to run.

Test Plan

cd services/commtest && COMM_TEST_TARGET=backup cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jun 13 2022, 6:51 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 13 2022, 6:51 AM
• karol edited the summary of this revision. (Show Details)Jun 13 2022, 7:21 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4248: [services] Tests - Add chunk limit to tools.
• karol added a child revision: D4250: [services] Tests - Add dummy tests.
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 13 2022, 10:04 AM
Harbormaster failed remote builds in B9725: Diff 13470!
• karol requested review of this revision.Jun 14 2022, 1:44 AM

CI failed on an unrelated stage - key server
CI services build - no space left on device

Harbormaster completed remote builds in B9725: Diff 13470.Jun 14 2022, 3:28 AM
ashoat accepted this revision.Jun 14 2022, 9:50 AM

Please always put me as a reviewer on diffs that touch external dependencies. Full list of situations to add me here

ashoat added a comment.Jun 14 2022, 9:50 AM

We're making sure none of these are copyleft-licensed, right? (eg GPL)

varun added a comment.Jun 14 2022, 9:56 AM
In D4249#120152, @ashoat wrote:

We're making sure none of these are copyleft-licensed, right? (eg GPL)

They're all MIT/Apache

varun accepted this revision.Jun 14 2022, 9:57 AM
This revision is now accepted and ready to land.Jun 14 2022, 9:57 AM
• karol updated this revision to Diff 14015.Jun 30 2022, 2:59 AM
• karol edited the summary of this revision. (Show Details)

retrigger CI

Harbormaster completed remote builds in B10145: Diff 14015.Jun 30 2022, 7:41 AM
Closed by commit rCOMM3871d95d9e36: [services] Tests - Update packages (authored by • karol). · Explain WhyJul 8 2022, 2:30 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM3871d95d9e36: [services] Tests - Update packages.

Revision Contents
Changeset List

PathSize
services/
commtest/
6 lines

Diff 14015

View Options

services/commtest/Cargo.lock

Loading...
View Options

services/commtest/Cargo.toml

Loading...