Page MenuHomePhabricator
Differential D4515

[keyserver] Rename COMM_MYSQL env variables to COMM_DATABASE
ClosedPublic
Actions

Authored by ashoat on Jul 13 2022, 7:07 AM.
Tags
None
Referenced Files
F2204320: D4515.id14547.diff
Sat, Jul 6, 3:54 PM
F2204319: D4515.id14541.diff
Sat, Jul 6, 3:54 PM
F2204318: D4515.id14433.diff
Sat, Jul 6, 3:54 PM
Unknown Object (File)
Sat, Jul 6, 11:07 AM
Unknown Object (File)
Sat, Jul 6, 11:07 AM
Unknown Object (File)
Wed, Jul 3, 6:04 AM
Unknown Object (File)
Wed, Jun 26, 12:55 AM
Unknown Object (File)
Wed, Jun 26, 12:54 AM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
• jon
atul
tomek
Commits
rCOMMe42b5ff59594: [keyserver] Rename COMM_MYSQL env variables to COMM_DATABASE
Summary

See feedback here.

Test Plan

I git grep for each variable name to make sure the spelling was correct, and I made sure the number of results matched my expectations

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/mariadb
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 13 2022, 7:07 AM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 13 2022, 7:07 AM
ashoat added a parent revision: D4500: [keyserver] Force sorting of inner fetchMessageInfos query on MariaDB.Jul 13 2022, 7:07 AM
ashoat mentioned this in D4499: [keyserver] Switch Docker Compose from MySQL 5.7 to MariaDB 10.8.
ashoat added a child revision: D4516: [keyserver] Add dbType to DBConfig.Jul 13 2022, 7:16 AM
Harbormaster completed remote builds in B10486: Diff 14433.Jul 13 2022, 7:19 AM
ashoat requested review of this revision.Jul 13 2022, 7:19 AM
• jon accepted this revision.Jul 13 2022, 12:28 PM

Makes sense

This revision is now accepted and ready to land.Jul 13 2022, 12:28 PM
ashoat added a child revision: D4529: [keyserver] Type ConnectionOptions passed to mysql2 library.Jul 13 2022, 4:50 PM
ashoat removed a child revision: D4516: [keyserver] Add dbType to DBConfig.Jul 13 2022, 4:57 PM
ashoat updated this revision to Diff 14541.Jul 17 2022, 8:05 PM

Rebase so this is below D4499

ashoat added a child revision: D4516: [keyserver] Add dbType to DBConfig.Jul 17 2022, 8:09 PM
This revision was landed with ongoing or failed builds.Jul 17 2022, 8:13 PM
Closed by commit rCOMMe42b5ff59594: [keyserver] Rename COMM_MYSQL env variables to COMM_DATABASE (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe42b5ff59594: [keyserver] Rename COMM_MYSQL env variables to COMM_DATABASE.
Harbormaster completed remote builds in B10566: Diff 14541.Jul 17 2022, 8:17 PM

Revision Contents
Changeset List

PathSize
keyserver/
14 lines
src/
database/
14 lines

Diff 14433

View Options

keyserver/docker-compose.yml

Loading...
View Options

keyserver/src/database/db-config.js

Loading...