[services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros
ClosedPublic
Actions

Authored by • max on Sep 29 2022, 5:36 AM.

Details

Reviewers

• jon
michal
marcin
varun
tomek

Commits

rCOMMde96baf6bece: [services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros

Summary

This diff introduces a minor refactoring to use bail and ensure Anyhow macros.
This is a more idiomatic way to use Anyhow and makes the code more readable.

Test Plan

Service is successfully built and the Rust function is successfully called from the C++ side.

Diff Detail

Repository

rCOMM Comm

Branch

changes-to-use-bail-and-ensure

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Sep 29 2022, 5:36 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 29 2022, 5:36 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5261: [services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib`.Sep 29 2022, 5:37 AM

Harbormaster completed remote builds in B12522: Diff 17184.Sep 29 2022, 5:46 AM

• max published this revision for review.Sep 29 2022, 6:05 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: michal, tomek.

• max edited the summary of this revision. (Show Details)

tomek edited reviewers, added: marcin; removed: tomek.Sep 29 2022, 7:08 AM

ashoat added a reviewer: varun.Sep 29 2022, 9:13 AM

• jon accepted this revision.Sep 29 2022, 9:43 AM

marcin accepted this revision.Sep 30 2022, 1:29 AM

marcin added a reviewer: tomek.

tomek accepted this revision.Sep 30 2022, 6:15 AM

This revision is now accepted and ready to land.Sep 30 2022, 6:15 AM

Closed by commit rCOMMde96baf6bece: [services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros (authored by • max). · Explain WhySep 30 2022, 7:38 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMde96baf6bece: [services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

rust-lib/

src/

notifications/

apns.rs

12 lines

fcm.rs

18 lines

Diff 17184

View Options

services/tunnelbroker/rust-lib/src/notifications/apns.rs