[native] [4/34] ReactNav6: update LinkTo to accept screen name
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:10 AM.

Details

Reviewers

atul
tomek
bartek

Commits

rCOMM921a800c6ac6: [native] [4/34] ReactNav6: update LinkTo to accept screen name

Summary

Context on change here.

Depends on D5396

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 20 2022, 6:10 AM

Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:10 AM

ashoat added a child revision: D5398: [native] [5/34] ReactNav6: Type getComponent prop of ScreenComponent.Oct 20 2022, 6:11 AM

Harbormaster completed remote builds in B12884: Diff 17675.Oct 20 2022, 6:23 AM

ashoat requested review of this revision.Oct 20 2022, 6:23 AM

Doesn't look like we're using <Link> component anywhere in the app.. flow types look fine though.

Checked against TypeScript types: https://github.com/react-navigation/react-navigation/blob/a2e5f45c0ec603bb276c2e27595b4137fa3a85eb/packages/native/src/useLinkTo.tsx#L10 and things look consistent (very little familiarity w/ typescript but at a glance)

This revision is now accepted and ready to land.Oct 20 2022, 9:36 AM

Closed by commit rCOMM921a800c6ac6: [native] [4/34] ReactNav6: update LinkTo to accept screen name (authored by ashoat). · Explain WhyOct 20 2022, 1:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM921a800c6ac6: [native] [4/34] ReactNav6: update LinkTo to accept screen name.

Revision Contents
Changeset List

Path

Size

native/

flow-typed/

npm/

@react-navigation/

native_v5.x.x.js

21 lines

Diff 17675

View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

[native] [4/34] ReactNav6: update LinkTo to accept screen nameClosedPublicActions