Page MenuHomePhabricator
Differential D5398

[native] [5/34] ReactNav6: Type getComponent prop of ScreenComponent
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 12:13 PM
Unknown Object (File)
Thu, Apr 17, 11:58 AM
Unknown Object (File)
Wed, Apr 16, 9:34 PM
Unknown Object (File)
Tue, Apr 15, 10:47 PM
Unknown Object (File)
Sat, Apr 12, 11:11 PM
Unknown Object (File)
Wed, Apr 9, 3:12 AM
Unknown Object (File)
Wed, Apr 9, 3:12 AM
Unknown Object (File)
Wed, Apr 9, 3:12 AM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMM332a9e8bb375: [native] [5/34] ReactNav6: Type getComponent prop of ScreenComponent
Summary

This actually doesn't appear to be new in ReactNav6. I noticed the libdef was incorrect when reviewing the docs.

Depends on D5397

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
30 lines
30 lines
30 lines
30 lines
30 lines

Diff 17676

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Show All 23 Lines
div.colorSelectorContainer { div.colorSelectorContainer {
margin-top: 8px; margin-top: 8px;
margin-bottom: 12px; margin-bottom: 12px;
} }
.save_button { .save_button {
width: 100%; width: 100%;
min-height: 46px;
aboshAuthorUnsubmitted
Done
Inline Actions

This is the current height of the Save button (technically it's 46.5px). This rule just ensures that when the content of the button changes (from 'Save' to the loading indicator) the button doesn't shrink or change its dimensions.

abosh: This is the current height of the Save button (technically it's `46.5px`). This rule just…
} }
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Show All 23 Lines
div.colorSelectorContainer { div.colorSelectorContainer {
margin-top: 8px; margin-top: 8px;
margin-bottom: 12px; margin-bottom: 12px;
} }
.save_button { .save_button {
width: 100%; width: 100%;
min-height: 46px;
aboshAuthorUnsubmitted
Done
Inline Actions

This is the current height of the Save button (technically it's 46.5px). This rule just ensures that when the content of the button changes (from 'Save' to the loading indicator) the button doesn't shrink or change its dimensions.

abosh: This is the current height of the Save button (technically it's `46.5px`). This rule just…
} }
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Show All 23 Lines
div.colorSelectorContainer { div.colorSelectorContainer {
margin-top: 8px; margin-top: 8px;
margin-bottom: 12px; margin-bottom: 12px;
} }
.save_button { .save_button {
width: 100%; width: 100%;
min-height: 46px;
aboshAuthorUnsubmitted
Done
Inline Actions

This is the current height of the Save button (technically it's 46.5px). This rule just ensures that when the content of the button changes (from 'Save' to the loading indicator) the button doesn't shrink or change its dimensions.

abosh: This is the current height of the Save button (technically it's `46.5px`). This rule just…
} }
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Show All 23 Lines
div.colorSelectorContainer { div.colorSelectorContainer {
margin-top: 8px; margin-top: 8px;
margin-bottom: 12px; margin-bottom: 12px;
} }
.save_button { .save_button {
width: 100%; width: 100%;
min-height: 46px;
aboshAuthorUnsubmitted
Done
Inline Actions

This is the current height of the Save button (technically it's 46.5px). This rule just ensures that when the content of the button changes (from 'Save' to the loading indicator) the button doesn't shrink or change its dimensions.

abosh: This is the current height of the Save button (technically it's `46.5px`). This rule just…
} }
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...