Paths

Table of Contentst

Differential D5403

[native] [10/34] ReactNav6: separate TabNavigationProp from TabNavigationHelpers
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:13 AM.

Tags

None

Referenced Files

	F3249362: D5403.diff
	Fri, Nov 15, 1:52 PM

	Unknown Object (File)
	Mon, Nov 11, 1:51 AM

	Unknown Object (File)
	Mon, Oct 28, 5:08 AM

	Unknown Object (File)
	Mon, Oct 28, 5:08 AM

	Unknown Object (File)
	Mon, Oct 28, 5:05 AM

	Unknown Object (File)
	Sep 26 2024, 7:08 PM

	Unknown Object (File)
	Sep 26 2024, 7:08 PM

	Unknown Object (File)
	Sep 26 2024, 7:07 PM

Subscribers

Details

Reviewers

atul
tomek
bartek

Commits

rCOMMa37506bc522d: [native] [10/34] ReactNav6: separate TabNavigationProp from TabNavigationHelpers

Summary

We want to type setParams correctly for both the specific-screen and any-screen-on-a-navigator case. As a result, the type of setParams is incompatible between the two.

The previous diff handled Stack, which is used a lot in the app. This diff handles Tab, which is used less in the app... but since there are three ReactNav packages with Tab navigators, this diff involves more changes to the libdefs.

Depends on D5402

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 20 2022, 6:13 AM

Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:13 AM

ashoat added a child revision: D5404: [native] [11/34] ReactNav6: separate DrawerNavigationProp from DrawerNavigationHelpers.Oct 20 2022, 6:13 AM

Harbormaster completed remote builds in B12890: Diff 17681.Oct 20 2022, 6:37 AM

ashoat requested review of this revision.Oct 20 2022, 6:37 AM

atul accepted this revision.Oct 20 2022, 9:56 AM

This revision is now accepted and ready to land.Oct 20 2022, 9:56 AM

Closed by commit rCOMMa37506bc522d: [native] [10/34] ReactNav6: separate TabNavigationProp from TabNavigationHelpers (authored by ashoat). · Explain WhyOct 20 2022, 1:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa37506bc522d: [native] [10/34] ReactNav6: separate TabNavigationProp from TabNavigationHelpers.

Revision Contents
Changeset List

Path

Size

native/

flow-typed/

npm/

@react-navigation/

bottom-tabs_v5.x.x.js

142 lines

devtools_v5.x.x.js

142 lines

material-top-tabs_v5.x.x.js

142 lines

native_v5.x.x.js

142 lines

stack_v5.x.x.js

142 lines

navigation/

app-navigator.react.js

7 lines

Diff 17681

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...

native/navigation/app-navigator.react.js

Loading...