Page MenuHomePhabricator
Differential D5425

[native] [32/34] ReactNav6: Update MaterialTopTabsNavigator
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:20 AM.
Tags
None
Referenced Files
F3248912: D5425.diff
Fri, Nov 15, 11:22 AM
Unknown Object (File)
Mon, Nov 11, 1:51 AM
Unknown Object (File)
Fri, Nov 8, 12:44 PM
Unknown Object (File)
Sat, Nov 2, 7:41 AM
Unknown Object (File)
Oct 6 2024, 1:45 AM
Unknown Object (File)
Oct 6 2024, 1:45 AM
Unknown Object (File)
Oct 6 2024, 1:44 AM
Unknown Object (File)
Oct 6 2024, 1:39 AM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMMdfb194a3df93: [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator
Summary

Context on changes in this section.

Depends on D5424

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 20 2022, 6:20 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:20 AM
ashoat added a child revision: D5426: [native] [33/34] ReactNav6: Update HeaderTitle to use flex positioning.Oct 20 2022, 6:21 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 6:45 AM
Harbormaster failed remote builds in B12912: Diff 17703!
ashoat requested review of this revision.Oct 20 2022, 7:25 AM

Build failures are caused by use of @react-navigation/elements in D5420, which isn't introduced until D5427. Sorry!!

atul accepted this revision.Oct 20 2022, 1:18 PM
This revision is now accepted and ready to land.Oct 20 2022, 1:18 PM
This revision was landed with ongoing or failed builds.Oct 20 2022, 1:48 PM
Closed by commit rCOMMdfb194a3df93: [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMdfb194a3df93: [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator.

Revision Contents
Changeset List

PathSize
native/
chat/
12 lines
flow-typed/
npm/
@react-navigation/
49 lines
49 lines
49 lines
49 lines
49 lines
49 lines

Diff 17703

View Options

native/chat/chat.react.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/elements_v1.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...