Page MenuHomePhabricator
Differential D5427

[native] [34/34] ReactNav6: Update package versions
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 4:01 AM
Unknown Object (File)
Mon, Nov 11, 1:51 AM
Unknown Object (File)
Fri, Nov 8, 8:17 PM
Unknown Object (File)
Fri, Nov 8, 8:15 PM
Unknown Object (File)
Sun, Nov 3, 7:46 PM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
View All Files
Subscribers
• abosh
• derek

Details

Reviewers
atul
tomek
bartek
• derek
Commits
rCOMM8760eb9609f3: [native] [34/34] ReactNav6: Update package versions
Summary

Exciting!!

Depends on D5426

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 20 2022, 6:21 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:21 AM
Harbormaster completed remote builds in B12914: Diff 17705.Oct 20 2022, 7:24 AM
ashoat requested review of this revision.Oct 20 2022, 7:24 AM
ashoat mentioned this in D5420: [native] [27/34] ReactNav6: Move some stack exports to elements.Oct 20 2022, 7:24 AM
ashoat mentioned this in D5421: [native] [28/34] ReactNav6: Specify headerShown: false for tab bar.
ashoat mentioned this in D5422: [native] [29/34] ReactNav6: Merge tabBarOptions into options.
ashoat mentioned this in D5423: [native] [30/34] ReactNav6: Remove tabBarVisible option.
ashoat mentioned this in D5424: [native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options.
ashoat mentioned this in D5425: [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator.
ashoat mentioned this in D5426: [native] [33/34] ReactNav6: Update HeaderTitle to use flex positioning.
• derek accepted this revision.Oct 20 2022, 12:09 PM
• derek added a subscriber: • derek.

ran the app on my phone, played around with it.
the navigation action to a threaded chat took a while for the screen to animate after the press
ran it again in release mode and it was snappy.
let er rip

This revision is now accepted and ready to land.Oct 20 2022, 12:09 PM
Closed by commit rCOMM8760eb9609f3: [native] [34/34] ReactNav6: Update package versions (authored by ashoat). · Explain WhyOct 20 2022, 1:48 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM8760eb9609f3: [native] [34/34] ReactNav6: Update package versions.

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
bottom-tabs_v6.x.x.js
bottom-tabs_v5.x.x.js
devtools_v6.x.x.js
devtools_v5.x.x.js
material-top-tabs_v6.x.x.js
material-top-tabs_v5.x.x.js
native_v6.x.x.js
native_v5.x.x.js
stack_v6.x.x.js
stack_v5.x.x.js
ios/
16 lines
16 lines
226 lines

Diff 17790

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v6.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v6.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v6.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v6.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v6.x.x.js

Loading...
View Options

native/ios/Podfile.lock

Loading...
View Options

native/package.json

Loading...
View Options

yarn.lock

Loading...