Page MenuHomePhabricator

[lib] introduced shimUnsupportedMessageInfo function to reaction message spec
ClosedPublic

Authored by ginsu on Nov 28 2022, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 1:00 AM
Unknown Object (File)
Fri, Oct 25, 9:27 PM
Unknown Object (File)
Wed, Oct 16, 7:50 PM
Unknown Object (File)
Oct 12 2024, 2:31 PM
Unknown Object (File)
Oct 2 2024, 8:32 PM
Unknown Object (File)
Sep 28 2024, 5:21 AM
Unknown Object (File)
Sep 28 2024, 5:21 AM
Unknown Object (File)
Sep 28 2024, 5:21 AM
Subscribers

Details

Summary

introduced shimUnsupportedMessageInfo function in reaction message spec. shimUnsupportedMessageInfo checks if the user is below the min code version which supports reactions and if that is the case returns an unsupported message info. The robotext for this unsupported message info is "user sent a reaction".

Before landing this diff I will go back and change the minCodeVersion to be accurate to where we currently are


Depends on D5690
Linear Task: ENG-2245

Test Plan

Please see the screenshots below to see what happens when the reaction message is "unsupported"

What it looks like on the app

Screenshot 2022-11-28 at 11.24.26 AM.png (1×1 px, 826 KB)

The messageInfo object

Screenshot 2022-11-28 at 11.25.24 AM.png (568×846 px, 262 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Nov 28 2022, 4:08 PM
atul retitled this revision from [lib] introduced shimUnsupportedMessageInfo functino to reaction message spec to [lib] introduced shimUnsupportedMessageInfo function to reaction message spec.Nov 28 2022, 4:09 PM
This revision is now accepted and ready to land.Nov 28 2022, 4:21 PM

Before landing this diff I will go back and change the minCodeVersion to be accurate to where we currently are

Will create a separate diff today/tomorrow to address this

In D5746#176062, @ginsu wrote:

Before landing this diff I will go back and change the minCodeVersion to be accurate to where we currently are

Will create a separate diff today/tomorrow to address this

It is usually better to wait with setting the version to just before the release. Even if we set the current version now, we might decide later to release a new bugfix and we would have to remember about updating this again to avoid releasing the feature by mistake.