Made changes to messagePreviewText to handle reaction message types. We will need this for the messageTitle function in the reaction message spec. For now, I am going with a generic text format of "someone reacted to a message", but will probably change the content when we get further along with the message liking implementation.
Details
Details
Ran web and mobile app locally and nothing crashes/will be testing more in subsequent diffs
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/message-utils.js | ||
|---|---|---|
| 296 ↗ | (On Diff #18608) | Is this function only used from lib/shared/messages/multimedia-message-spec.js? Today? Wondering if the logic should just be moved into the individual message specs... what do you think? |
Comment Actions
Making changes based on ashaoat's comments to put messagePreviewText into the individual message specs
| lib/shared/message-utils.js | ||
|---|---|---|
| 296 ↗ | (On Diff #18608) | That is correct, messagePreviewText is only called in lib/shared/messages/multimedia-message-spec.js
I will do this, I feel like it will help keep the message specs more modular |
Comment Actions
rebase, and realized it is going to be easier land this diff and then to address ashoat's comments in a followup diff