[lib] added reaction type to local unshim types
ClosedPublic
Actions

Authored by ginsu on Dec 5 2022, 7:09 PM.

Details

Reviewers

atul
tomek
rohan

Commits

rCOMM6368800cedd8: [lib] added reaction type to local unshim types

Summary

added reaction type to local unshim types. This is so reaction messages will now be unshimed with the rest of new message types introduced throughout the years

Linear Task: ENG-2247

Depends on D5805 and D5752

Test Plan

I was able to get messages to render correctly on the UI. This makes me feel very confident that this works as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 5 2022, 7:09 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 5 2022, 7:09 PM

ginsu edited the summary of this revision. (Show Details)Dec 5 2022, 7:11 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, tomek, rohan.

ginsu attached a referenced file: F272597: Screen Recording 2022-12-05 at 8.35.02 PM.mov. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D5805: [lib] introduce unshimMessageInfo to reaction message spec.

ginsu edited the summary of this revision. (Show Details)Dec 5 2022, 7:17 PM

ginsu added a parent revision: D5752: [lib] introduce SendReactionMessageRequest type to message types.

Harbormaster completed remote builds in B13986: Diff 19159.Dec 5 2022, 7:19 PM

ginsu requested review of this revision.Dec 5 2022, 7:19 PM

tomek accepted this revision.Dec 6 2022, 8:47 AM

rohan accepted this revision.Dec 7 2022, 10:01 AM

As a side note, looks like there's some visual weirdness in the attached video that we'll need to address

This revision is now accepted and ready to land.Dec 7 2022, 12:03 PM

In D5817#174385, @atul wrote:

As a side note, looks like there's some visual weirdness in the attached video that we'll need to address

Follow up task for this

rebase before landing

Harbormaster completed remote builds in B14603: Diff 19921.Dec 20 2022, 4:59 PM

Closed by commit rCOMM6368800cedd8: [lib] added reaction type to local unshim types (authored by ginsu). · Explain WhyDec 20 2022, 5:03 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM6368800cedd8: [lib] added reaction type to local unshim types.

Revision Contents
Changeset List

Path

Size

lib/

shared/

unshim-utils.js

1 line

Diff 19923

View Options

lib/shared/unshim-utils.js

[lib] added reaction type to local unshim typesClosedPublicActions